Changeset 59581 in webkit

Timestamp:

May 16, 2010 2:08:53 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

• fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
• fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
• fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):
• platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

• dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt (added)
• LayoutTests/fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html (added)
• LayoutTests/fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js (added)
• LayoutTests/platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/CanvasSurface.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-05-16  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
+        https://bugs.webkit.org/show_bug.cgi?id=39153
+
+        Spec link:
+        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl
+
+        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
+        * fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
+        * fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added.
+        (tryMimeType):
+        * platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
+
 2010-05-16  Robert Hogan  <robert@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-16  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
+        https://bugs.webkit.org/show_bug.cgi?id=39153
+
+        Spec link:
+        http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl
+
+        Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
+
+        * dom/CanvasSurface.cpp:
+        (WebCore::CanvasSurface::toDataURL):
+
 2010-05-16  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/dom/CanvasSurface.cpp

@@ -75 +75 @@
         return String("data:,");
 
+    String lowercaseMimeType = mimeType.lower();
+
     // FIXME: Make isSupportedImageMIMETypeForEncoding threadsafe (to allow this method to be used on a worker thread).
-    if (mimeType.isNull() || !MIMETypeRegistry::isSupportedImageMIMETypeForEncoding(mimeType))
+    if (mimeType.isNull() || !MIMETypeRegistry::isSupportedImageMIMETypeForEncoding(lowercaseMimeType))
         return buffer()->toDataURL("image/png");
 
-    return buffer()->toDataURL(mimeType);
+    return buffer()->toDataURL(lowercaseMimeType);
 }