Changeset 60067 in webkit


Ignore:
Timestamp:
May 24, 2010 3:17:20 AM (14 years ago)
Author:
jorlow@chromium.org
Message:

2010-05-21 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Alexey Proskuryakov.

Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop
​https://bugs.webkit.org/show_bug.cgi?id=39429

Added new constructor for DOMStringsList, so updating the existing
expected results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:

2010-05-20 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Alexey Proskuryakov.

Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop
​https://bugs.webkit.org/show_bug.cgi?id=39429

IndexedDB depends on DOMStringList.
​http://dev.w3.org/2006/webapi/WebSimpleDB/#idl-def-IDBDatabase
It's currently specced here:
​http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList

Existing tests cover the constructor. IndexedDB will also use this
soon (and thus add test coverage).

  • Android.mk:
  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/DOMStringList.h: Added. (WebCore::DOMStringList::create): (WebCore::DOMStringList::length): (WebCore::DOMStringList::item): (WebCore::DOMStringList::isEmpty): (WebCore::DOMStringList::clear): (WebCore::DOMStringList::append): (WebCore::DOMStringList::DOMStringList):
  • dom/DOMStringList.idl: Added.
  • page/DOMWIndow.idl: Re-enabled constructor
Location:
trunk
Files:
3 added
21 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r60065 r60067  
     12010-05-21  Jeremy Orlow  <jorlow@chromium.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop
     6        https://bugs.webkit.org/show_bug.cgi?id=39429
     7
     8        Added new constructor for DOMStringsList, so updating the existing
     9        expected results.
     10
     11        * fast/dom/Window/window-properties-expected.txt:
     12        * fast/dom/Window/window-property-descriptors-expected.txt:
     13        * fast/dom/prototype-inheritance-2-expected.txt:
     14        * fast/dom/prototype-inheritance-expected.txt:
     15        * fast/js/global-constructors-expected.txt:
     16
    1172010-05-24  Shinichiro Hamaji  <hamaji@chromium.org>
    218

  • trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

    r59010 r60067  
    546546window.DOMParser.prototype [object DOMParserPrototype]
    547547window.DOMParser.prototype.parseFromString [function]
     548window.DOMStringList [object DOMStringListConstructor]
     549window.DOMStringList.prototype [object DOMStringListPrototype]
     550window.DOMStringList.prototype.item [function]
    548551window.Document [object DocumentConstructor]
    549552window.Document.prototype [object DocumentPrototype]

  • trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt

    r59010 r60067  
    3636PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMImplementation') is 'object'
    3737PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMParser') is 'object'
     38PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMStringList') is 'object'
    3839PASS typeof Object.getOwnPropertyDescriptor(window, 'Date') is 'object'
    3940PASS typeof Object.getOwnPropertyDescriptor(window, 'Document') is 'object'

  • trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

    r59010 r60067  
    216216Never found Clipboard
    217217Never found DOMParser
     218Never found DOMStringList
    218219Never found Document
    219220Never found DocumentFragment

  • trunk/LayoutTests/fast/dom/prototype-inheritance-expected.txt

    r59941 r60067  
    6464PASS inner.DOMParser.isInner is true
    6565PASS inner.DOMParser.constructor.isInner is true
     66PASS inner.DOMStringList.isInner is true
     67PASS inner.DOMStringList.constructor.isInner is true
    6668PASS inner.Document.isInner is true
    6769PASS inner.Document.constructor.isInner is true

  • trunk/LayoutTests/fast/js/global-constructors-expected.txt

    r59010 r60067  
    3434PASS DOMImplementation.toString() is '[object DOMImplementationConstructor]'
    3535PASS DOMParser.toString() is '[object DOMParserConstructor]'
     36PASS DOMStringList.toString() is '[object DOMStringListConstructor]'
    3637PASS Document.toString() is '[object DocumentConstructor]'
    3738PASS DocumentFragment.toString() is '[object DocumentFragmentConstructor]'

  • trunk/WebCore/Android.derived.jscbindings.mk

    r59847 r60067  
    104104    $(intermediates)/dom/JSDOMCoreException.h \
    105105    $(intermediates)/dom/JSDOMImplementation.h \
     106    $(intermediates)/dom/JSDOMStringList.h \
    106107    $(intermediates)/dom/JSDeviceOrientationEvent.h \
    107108    $(intermediates)/dom/JSDocument.h \

  • trunk/WebCore/Android.derived.v8bindings.mk

    r59847 r60067  
    8686    $(intermediates)/bindings/V8DOMCoreException.h \
    8787    $(intermediates)/bindings/V8DOMImplementation.h \
     88    $(intermediates)/bindings/V8DOMStringList.h \
    8889    $(intermediates)/bindings/V8DeviceOrientationEvent.h \
    8990    $(intermediates)/bindings/V8Document.h \

  • trunk/WebCore/Android.mk

    r60056 r60067  
    113113        dom/ContainerNode.cpp \
    114114        dom/DOMImplementation.cpp \
     115        dom/DOMStringList.cpp \
    115116        dom/Document.cpp \
    116117        dom/DocumentFragment.cpp \

  • trunk/WebCore/CMakeLists.txt

    r60056 r60067  
    140140    dom/DOMCoreException.idl
    141141    dom/DOMImplementation.idl
     142    dom/DOMStringList.idl
    142143    dom/DeviceOrientationEvent.idl
    143144    dom/Document.idl
    … …  
    761762    dom/CustomEvent.cpp
    762763    dom/DOMImplementation.cpp
     764<<<<<<< HEAD
    763765    dom/DeviceOrientation.cpp
    764766    dom/DeviceOrientationEvent.cpp
     767=======
     768    dom/DOMStringList.cpp
     769>>>>>>> x
    765770    dom/Document.cpp
    766771    dom/DocumentFragment.cpp

  • trunk/WebCore/ChangeLog

    r60063 r60067  
     12010-05-20  Jeremy Orlow  <jorlow@chromium.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop
     6        https://bugs.webkit.org/show_bug.cgi?id=39429
     7
     8        IndexedDB depends on DOMStringList.
     9        http://dev.w3.org/2006/webapi/WebSimpleDB/#idl-def-IDBDatabase
     10        It's currently specced here:
     11        http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
     12
     13        Existing tests cover the constructor.  IndexedDB will also use this
     14        soon (and thus add test coverage).
     15
     16        * Android.mk:
     17        * Android.derived.jscbindings.mk:
     18        * Android.derived.v8bindings.mk:
     19        * CMakeLists.txt:
     20        * DerivedSources.cpp:
     21        * DerivedSources.make:
     22        * GNUmakefile.am:
     23        * WebCore.gypi:
     24        * WebCore.pri:
     25        * WebCore.pro:
     26        * WebCore.vcproj/WebCore.vcproj:
     27        * WebCore.xcodeproj/project.pbxproj:
     28        * bindings/scripts/CodeGeneratorJS.pm:
     29        * dom/DOMStringList.h: Added.
     30        (WebCore::DOMStringList::create):
     31        (WebCore::DOMStringList::length):
     32        (WebCore::DOMStringList::item):
     33        (WebCore::DOMStringList::isEmpty):
     34        (WebCore::DOMStringList::clear):
     35        (WebCore::DOMStringList::append):
     36        (WebCore::DOMStringList::DOMStringList):
     37        * dom/DOMStringList.idl: Added.
     38        * page/DOMWIndow.idl: Re-enabled constructor
     39
    1402010-05-23  Shinichiro Hamaji  <hamaji@chromium.org>
    241

  • trunk/WebCore/DerivedSources.cpp

    r59847 r60067  
    8080#include "JSDOMParser.cpp"
    8181#include "JSDOMSelection.cpp"
     82#include "JSDOMStringList.cpp"
    8283#include "JSDOMWindow.cpp"
    8384#include "JSElement.cpp"

  • trunk/WebCore/DerivedSources.make

    r59847 r60067  
    114114    DOMParser \
    115115    DOMSelection \
     116    DOMStringList \
    116117    DOMWindow \
    117118    Database \

  • trunk/WebCore/GNUmakefile.am

    r60063 r60067  
    140140        WebCore/dom/DOMCoreException.idl \
    141141        WebCore/dom/DOMImplementation.idl \
     142        WebCore/dom/DOMStringList.idl \
    142143        WebCore/dom/DeviceOrientationEvent.idl \
    143144        WebCore/dom/Document.idl \
    … …  
    771772        WebCore/dom/DOMImplementation.cpp \
    772773        WebCore/dom/DOMImplementation.h \
     774        WebCore/dom/DOMStringList.cpp \
     775        WebCore/dom/DOMStringList.h \
    773776        WebCore/dom/DeviceOrientation.cpp \
    774777        WebCore/dom/DeviceOrientation.h \
    … …  
    39103913        WebCore/dom/DocumentType.idl \
    39113914        WebCore/dom/DOMImplementation.idl \
     3915        WebCore/dom/DOMStringList.idl \
    39123916        WebCore/dom/Element.idl \
    39133917        WebCore/dom/EntityReference.idl \

  • trunk/WebCore/WebCore.gypi

    r60063 r60067  
    4141            'dom/DOMCoreException.idl',
    4242            'dom/DOMImplementation.idl',
     43            'dom/DOMStringList.idl',
    4344            'dom/DeviceOrientationEvent.idl',
    4445            'dom/Document.idl',
    … …  
    11031104            'dom/DOMImplementation.cpp',
    11041105            'dom/DOMImplementation.h',
     1106            'dom/DOMStringList.cpp',
     1107            'dom/DOMStringList.h',
    11051108            'dom/DeviceOrientation.cpp',
    11061109            'dom/DeviceOrientation.h',

  • trunk/WebCore/WebCore.pri

    r59847 r60067  
    267267    dom/DOMCoreException.idl \
    268268    dom/DOMImplementation.idl \
     269    dom/DOMStringList.idl \
    269270    dom/Element.idl \
    270271    dom/Entity.idl \

  • trunk/WebCore/WebCore.pro

    r60063 r60067  
    471471    dom/DocumentType.cpp \
    472472    dom/DOMImplementation.cpp \
     473    dom/DOMStringList.cpp \
    473474    dom/DynamicNodeList.cpp \
    474475    dom/EditingText.cpp \
    … …  
    12001201    dom/DocumentType.h \
    12011202    dom/DOMImplementation.h \
     1203    dom/DOMStringList.h \
    12021204    dom/DynamicNodeList.h \
    12031205    dom/EditingText.h \

  • trunk/WebCore/WebCore.vcproj/WebCore.vcproj

    r60063 r60067  
    32983298                        </File>
    32993299                        <File
     3300                                RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSDOMStringList.cpp"
     3301                                >
     3302                                <FileConfiguration
     3303                                        Name="Debug|Win32"
     3304                                        ExcludedFromBuild="true"
     3305                                        >
     3306                                        <Tool
     3307                                                Name="VCCLCompilerTool"
     3308                                        />
     3309                                </FileConfiguration>
     3310                                <FileConfiguration
     3311                                        Name="Release|Win32"
     3312                                        ExcludedFromBuild="true"
     3313                                        >
     3314                                        <Tool
     3315                                                Name="VCCLCompilerTool"
     3316                                        />
     3317                                </FileConfiguration>
     3318                                <FileConfiguration
     3319                                        Name="Debug_Internal|Win32"
     3320                                        ExcludedFromBuild="true"
     3321                                        >
     3322                                        <Tool
     3323                                                Name="VCCLCompilerTool"
     3324                                        />
     3325                                </FileConfiguration>
     3326                                <FileConfiguration
     3327                                        Name="Debug_Cairo|Win32"
     3328                                        ExcludedFromBuild="true"
     3329                                        >
     3330                                        <Tool
     3331                                                Name="VCCLCompilerTool"
     3332                                        />
     3333                                </FileConfiguration>
     3334                                <FileConfiguration
     3335                                        Name="Release_Cairo|Win32"
     3336                                        ExcludedFromBuild="true"
     3337                                        >
     3338                                        <Tool
     3339                                                Name="VCCLCompilerTool"
     3340                                        />
     3341                                </FileConfiguration>
     3342                                <FileConfiguration
     3343                                        Name="Debug_All|Win32"
     3344                                        ExcludedFromBuild="true"
     3345                                        >
     3346                                        <Tool
     3347                                                Name="VCCLCompilerTool"
     3348                                        />
     3349                                </FileConfiguration>
     3350                        </File>
     3351                        <File
     3352                                RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSDOMStringList.h"
     3353                                >
     3354                        </File>
     3355                        <File
    33003356                                RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSDOMWindow.cpp"
    33013357                                >
    … …  
    2956229618                        </File>
    2956329619                        <File
     29620                                RelativePath="..\dom\DOMStringList.cpp"
     29621                                >
     29622                        </File>
     29623                        <File
     29624                                RelativePath="..\dom\DOMStringList.h"
     29625                                >
     29626                        </File>
     29627                        <File
    2956429628                                RelativePath="..\dom\DynamicNodeList.cpp"
    2956529629                                >

  • trunk/WebCore/WebCore.xcodeproj/project.pbxproj

    r60063 r60067  
    47744774                C5102ECF0FD9EF8C00FAFF04 /* StorageAreaSync.h in Headers */ = {isa = PBXBuildFile; fileRef = C5102ECD0FD9EF8C00FAFF04 /* StorageAreaSync.h */; };
    47754775                C5102ED00FD9EF8C00FAFF04 /* StorageAreaSync.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C5102ECE0FD9EF8C00FAFF04 /* StorageAreaSync.cpp */; };
     4776                C5137CF211A58378004ADB99 /* JSDOMStringList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C5137CF011A58378004ADB99 /* JSDOMStringList.cpp */; };
     4777                C5137CF311A58378004ADB99 /* JSDOMStringList.h in Headers */ = {isa = PBXBuildFile; fileRef = C5137CF111A58378004ADB99 /* JSDOMStringList.h */; };
    47764778                C5160EEA1004543A00A7CEE2 /* StorageAreaImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C5160EE81004543A00A7CEE2 /* StorageAreaImpl.cpp */; };
    47774779                C5160EEB1004543A00A7CEE2 /* StorageAreaImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = C5160EE91004543A00A7CEE2 /* StorageAreaImpl.h */; };
    … …  
    47914793                C5198F5D1192ECFD002B74A6 /* IndexedDatabaseRequest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C5198F491192ECFD002B74A6 /* IndexedDatabaseRequest.cpp */; };
    47924794                C5198F5E1192ECFD002B74A6 /* IndexedDatabaseRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = C5198F4A1192ECFD002B74A6 /* IndexedDatabaseRequest.h */; };
     4795                C544274B11A57E7A0063A749 /* DOMStringList.h in Headers */ = {isa = PBXBuildFile; fileRef = C544274911A57E7A0063A749 /* DOMStringList.h */; };
     4796                C55610F111A704EB00B82D27 /* DOMStringList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C55610F011A704EB00B82D27 /* DOMStringList.cpp */; };
    47934797                C55E38BF10040D5D00A56BDB /* StorageNamespaceImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = C55E38BB10040D5D00A56BDB /* StorageNamespaceImpl.h */; };
    47944798                C55E38C010040D5D00A56BDB /* StorageNamespaceImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C55E38BC10040D5D00A56BDB /* StorageNamespaceImpl.cpp */; };
    … …  
    1027410278                C5102ECD0FD9EF8C00FAFF04 /* StorageAreaSync.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StorageAreaSync.h; sourceTree = "<group>"; };
    1027510279                C5102ECE0FD9EF8C00FAFF04 /* StorageAreaSync.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StorageAreaSync.cpp; sourceTree = "<group>"; };
     10280                C5137CF011A58378004ADB99 /* JSDOMStringList.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMStringList.cpp; sourceTree = "<group>"; };
     10281                C5137CF111A58378004ADB99 /* JSDOMStringList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMStringList.h; sourceTree = "<group>"; };
    1027610282                C5160EE81004543A00A7CEE2 /* StorageAreaImpl.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StorageAreaImpl.cpp; sourceTree = "<group>"; };
    1027710283                C5160EE91004543A00A7CEE2 /* StorageAreaImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StorageAreaImpl.h; sourceTree = "<group>"; };
    … …  
    1029610302                C5198F4A1192ECFD002B74A6 /* IndexedDatabaseRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IndexedDatabaseRequest.h; sourceTree = "<group>"; };
    1029710303                C5198F4B1192ECFD002B74A6 /* IndexedDatabaseRequest.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = IndexedDatabaseRequest.idl; sourceTree = "<group>"; };
     10304                C544274911A57E7A0063A749 /* DOMStringList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMStringList.h; sourceTree = "<group>"; };
     10305                C544274A11A57E7A0063A749 /* DOMStringList.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMStringList.idl; sourceTree = "<group>"; };
     10306                C55610F011A704EB00B82D27 /* DOMStringList.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMStringList.cpp; sourceTree = "<group>"; };
    1029810307                C55E38BB10040D5D00A56BDB /* StorageNamespaceImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StorageNamespaceImpl.h; sourceTree = "<group>"; };
    1029910308                C55E38BC10040D5D00A56BDB /* StorageNamespaceImpl.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StorageNamespaceImpl.cpp; sourceTree = "<group>"; };
    … …  
    1426014269                                65DF31E309D1CC60000BE325 /* JSDOMImplementation.cpp */,
    1426114270                                65DF31E409D1CC60000BE325 /* JSDOMImplementation.h */,
     14271                                C5137CF011A58378004ADB99 /* JSDOMStringList.cpp */,
     14272                                C5137CF111A58378004ADB99 /* JSDOMStringList.h */,
    1426214273                                65DF31E509D1CC60000BE325 /* JSElement.cpp */,
    1426314274                                65DF31E609D1CC60000BE325 /* JSElement.h */,
    … …  
    1651916530                                A8185F3309765765005826D9 /* DOMImplementation.h */,
    1652016531                                93EEC1E909C2877700C515D1 /* DOMImplementation.idl */,
     16532                                C55610F011A704EB00B82D27 /* DOMStringList.cpp */,
     16533                                C544274911A57E7A0063A749 /* DOMStringList.h */,
     16534                                C544274A11A57E7A0063A749 /* DOMStringList.idl */,
    1652116535                                BC7FA61E0D1F0CBD00DB22A9 /* DynamicNodeList.cpp */,
    1652216536                                BC7FA61F0D1F0CBD00DB22A9 /* DynamicNodeList.h */,
    … …  
    1931319327                                A879C62611A9D1F70059237A /* HTML5TreeBuilder.h in Headers */,
    1931419328                                B734B183119B991D006587BD /* FontTranscoder.h in Headers */,
     19329                                C544274B11A57E7A0063A749 /* DOMStringList.h in Headers */,
     19330                                C5137CF311A58378004ADB99 /* JSDOMStringList.h in Headers */,
    1931519331                        );
    1931619332                        runOnlyForDeploymentPostprocessing = 0;
    … …  
    2160021616                                A879C62511A9D1F70059237A /* HTML5TreeBuilder.cpp in Sources */,
    2160121617                                B734B181119B9911006587BD /* FontTranscoder.cpp in Sources */,
     21618                                C5137CF211A58378004ADB99 /* JSDOMStringList.cpp in Sources */,
     21619                                C55610F111A704EB00B82D27 /* DOMStringList.cpp in Sources */,
    2160221620                        );
    2160321621                        runOnlyForDeploymentPostprocessing = 0;

  • trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r59941 r60067  
    227227    my $type = shift;
    228228
    229     return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "CSSVariablesDeclaration";
     229    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "CSSVariablesDeclaration" or $type eq "DOMStringList";
    230230    return 0;
    231231}

  • trunk/WebCore/page/DOMWindow.idl

    r59847 r60067  
    346346        // FIXME: Implement the commented-out global constructors for interfaces listed in DOM Level 3 Core specification.
    347347        attribute DOMCoreExceptionConstructor DOMException;
    348 //        attribute DOMStringListConstructor DOMStringList;
     348        attribute DOMStringListConstructor DOMStringList;
    349349//        attribute NameListConstructor NameList;
    350350//        attribute DOMImplementationListConstructor DOMImplementationList;
Note: See TracChangeset for help on using the changeset viewer.