Changeset 60158 in webkit

Timestamp:

May 25, 2010 6:13:51 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

editingBehavior settings needs to be set back to a reasonable default between tests
​https://bugs.webkit.org/show_bug.cgi?id=39433

Reviewed by Eric Seidel and Kent Tamura (Chromium part).
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
so that the serialized version of the setting stays in sync with expectations.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetWebSettings):

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/TestShell.cpp (modified) (1 diff)
• DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
+
+        editingBehavior settings needs to be set back to a reasonable default between tests
+        https://bugs.webkit.org/show_bug.cgi?id=39433
+
+        Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
+        so that the serialized version of the setting stays in sync with expectations.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::resetWebSettings):
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues):
+
 2010-05-24  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

@@ -175 +175 @@
     settings->setLoadsImagesAutomatically(true);
     settings->setImagesEnabled(true);
+
+#if OS(DARWIN)
+    settings->setEditingBehavior(WebSettings::EditingBehaviorMac);
+#else
+    settings->setEditingBehavior(WebSettings::EditingBehaviorWin);
+#endif
 }
 

trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -344 +344 @@
                  "enable-java-applet", FALSE,
                  "enable-plugins", TRUE,
+                 "editing-behavior", WEBKIT_EDITING_BEHAVIOR_WINDOWS,
                  NULL);