Changeset 60590 in webkit

Timestamp:

Jun 2, 2010 7:00:31 PM (14 years ago)

Author:

pkasting@chromium.org

Message:

Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
John Gregg).

Temporarily make notificationObjectDestroyed() a no-op to avoid an
ASSERT failure.

​https://bugs.webkit.org/show_bug.cgi?id=40097

• src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationObjectDestroyed):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/NotificationPresenterImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-06-02  Peter Kasting  <pkasting@google.com>
+
+        Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
+        John Gregg).
+
+        Temporarily make notificationObjectDestroyed() a no-op to avoid an
+        ASSERT failure.
+
+        https://bugs.webkit.org/show_bug.cgi?id=40097
+
+        * src/NotificationPresenterImpl.cpp:
+        (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
+
 2010-06-02  Sterling Swigart  <sswigart@google.com>
 

trunk/WebKit/chromium/src/NotificationPresenterImpl.cpp

@@ -89 +89 @@
 void NotificationPresenterImpl::notificationObjectDestroyed(Notification* notification)
 {
-    m_presenter->objectDestroyed(PassRefPtr<Notification>(notification));
+    // TODO(pkasting): We cannot ref an object that's being destroyed.  Either
+    // this function needs to be called earlier than in ~Notification(), or it
+    // needs to not ref this object.
+    //m_presenter->objectDestroyed(PassRefPtr<Notification>(notification));
 }