Changeset 60778 in webkit

Timestamp:

Jun 7, 2010 6:56:19 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Expose the editing behavior setting in DRT to test all editing code paths ​https://bugs.webkit.org/show_bug.cgi?id=39680

Patch by Antonio Gomes <​tonikitoo@webkit.org>, Laszlo Gombos <Laszlo Gombos> on 2010-06-06
Reviewed by Kenneth Christiansen, Eric Seidel.

Make setEditingBehavior() a no-operation if the editingBehavior
argument is not recognized to avoid using an uninitialized variable.

• WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setEditingBehavior):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/DumpRenderTreeSupportQt.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-06-06  Antonio Gomes  <tonikitoo@webkit.org>, Laszlo Gombos  <laszlo.1.gombos@nokia.com>
+
+        Reviewed by Kenneth Christiansen, Eric Seidel.
+
+        [Qt] Expose the editing behavior setting in DRT to test all editing code paths
+        https://bugs.webkit.org/show_bug.cgi?id=39680
+
+        Make setEditingBehavior() a no-operation if the editingBehavior
+        argument is not recognized to avoid using an uninitialized variable.
+
+        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+        (DumpRenderTreeSupportQt::setEditingBehavior):
+
 2010-06-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 

trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

@@ -483 +483 @@
     else if (editingBehavior == "mac")
         coreEditingBehavior = EditingMacBehavior;
+    else {
+        ASSERT_NOT_REACHED();
+        return;
+    }
 
     Page* corePage = QWebPagePrivate::core(page);