Changeset 60797 in webkit

Timestamp:

Jun 7, 2010 1:01:29 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-06-07 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] convert a key to AtomicString in V8NodeList::namedPropertyGetter
​https://bugs.webkit.org/show_bug.cgi?id=40238

Comparison to "length" below could be performed faster in this (major) case
as it would only require direct pointer comparison (cf. to full text
comparison if key is converted to WebCore::String.)

• bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8NodeListCustom.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-07  Anton Muhin  <antonm@chromium.org>
+
+        Reviewed by Nate Chapin.
+
+        [Chromium] convert a key to AtomicString in V8NodeList::namedPropertyGetter
+        https://bugs.webkit.org/show_bug.cgi?id=40238
+
+        Comparison to "length" below could be performed faster in this (major) case
+        as it would only require direct pointer comparison (cf. to full text
+        comparison if key is converted to WebCore::String.)
+
+        * bindings/v8/custom/V8NodeListCustom.cpp:
+        (WebCore::V8NodeList::namedPropertyGetter):
+
 2010-06-07  Ariya Hidayat  <ariya.hidayat@codeaurora.org>
 

trunk/WebCore/bindings/v8/custom/V8NodeListCustom.cpp

@@ -46 +46 @@
     INC_STATS("DOM.NodeList.NamedPropertyGetter");
     NodeList* list = V8NodeList::toNative(info.Holder());
-    String key = toWebCoreString(name);
+    AtomicString key = v8ValueToAtomicWebCoreString(name);
 
     // Length property cannot be overridden.