Changeset 60803 in webkit

Timestamp:

Jun 7, 2010 3:13:03 PM (14 years ago)

Author:

Martin Robinson

Message:

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Mouse movement should not trigger a replay of saved events in the event sender
​https://bugs.webkit.org/show_bug.cgi?id=40267

When a mouse button is down, automatically queue mouse motion events and
do not play them back until the mouse button is released. This matches the
behavior of other ports' EventSenders.

• DumpRenderTree/gtk/EventSender.cpp: (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion. (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/EventSender.cpp (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-06-07  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Oliver Hunt.
+
+        [GTK] Mouse movement should not trigger a replay of saved events in the event sender
+        https://bugs.webkit.org/show_bug.cgi?id=40267
+
+        When a mouse button is down, automatically queue mouse motion events and
+        do not play them back until the mouse button is released. This matches the
+        behavior of other ports' EventSenders.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
+        (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
+
 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/WebKitTools/DumpRenderTree/gtk/EventSender.cpp

@@ -84 +84 @@
 };
 
-static void sendOrQueueEvent(GdkEvent event);
+static void sendOrQueueEvent(GdkEvent, bool = true);
 static void dispatchEvent(GdkEvent event);
 static guint getStateFlags();
@@ -295 +295 @@
     event.motion.y_root = yRoot;
 
-    sendOrQueueEvent(event);
+    sendOrQueueEvent(event, false);
     return JSValueMakeUndefined(context);
 }
@@ -347 +347 @@
 }
 
-static void sendOrQueueEvent(GdkEvent event)
+static void sendOrQueueEvent(GdkEvent event, bool shouldReplaySavedEvents)
 {
     // Mouse move events are queued if the previous event was queued or if a
     // delay was set up by leapForward().
-    if (endOfQueue != startOfQueue || msgQueue[endOfQueue].delay) {
+    if (buttonCurrentlyDown || endOfQueue != startOfQueue || msgQueue[endOfQueue].delay) {
         msgQueue[endOfQueue++].event = event;
-        replaySavedEvents();
+
+        if (shouldReplaySavedEvents)
+            replaySavedEvents();
+
         return;
     }