Changeset 60827 in webkit


Ignore:
Timestamp:
Jun 8, 2010 12:20:06 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-06-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5Lexer does not handle <div FOO ><img><img></div> correctly
​https://bugs.webkit.org/show_bug.cgi?id=40283

  • html5lib/resources/webkit01.dat:
    • Add another test for this failure case.

2010-06-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5Lexer does not handle <div FOO ><img><img></div> correctly
​https://bugs.webkit.org/show_bug.cgi?id=40283

Fix a typo in the AfterAttributeNameState.
The compiler really should have caught this since the typo
resulted in unreachable code.

Tests:

10 tables/mozilla/marvin/colgroup* tests.
Also added a new sub-test in html5lib/resources/webkit01.dat

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
    • Fix typo of = instead of >
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r60824 r60827  
     12010-06-07  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        HTML5Lexer does not handle <div FOO ><img><img></div> correctly
     6        https://bugs.webkit.org/show_bug.cgi?id=40283
     7
     8        * html5lib/resources/webkit01.dat:
     9         - Add another test for this failure case.
     10
    1112010-06-08  Adam Barth  <abarth@webkit.org>
    212

  • trunk/LayoutTests/html5lib/resources/webkit01.dat

    r60465 r60827  
    166166|   <head>
    167167|   <body>
     168
     169#data
     170<div FOO ><img><img></div>
     171#errors
     172#document
     173| <html>
     174|   <head>
     175|   <body>
     176|     <div>
     177|       foo=""
     178|       <img>
     179|       <img>

  • trunk/WebCore/ChangeLog

    r60826 r60827  
     12010-06-07  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        HTML5Lexer does not handle <div FOO ><img><img></div> correctly
     6        https://bugs.webkit.org/show_bug.cgi?id=40283
     7
     8        Fix a typo in the AfterAttributeNameState.
     9        The compiler really should have caught this since the typo
     10        resulted in unreachable code.
     11
     12        Tests:
     13         10 tables/mozilla/marvin/colgroup* tests.
     14         Also added a new sub-test in html5lib/resources/webkit01.dat
     15
     16        * html/HTML5Lexer.cpp:
     17        (WebCore::HTML5Lexer::nextToken):
     18         - Fix typo of = instead of >
     19
    1202010-06-08  Adam Barth  <abarth@webkit.org>
    221

  • trunk/WebCore/WebCore.xcodeproj/project.pbxproj

    r60820 r60827  
    1943319433                                9FFE3EA611B5A4390037874E /* JSMemoryInfo.h in Headers */,
    1943419434                                86243D0111BC31F700CC006A /* JSArrayBufferViewHelper.h in Headers */,
    19435                                 A7BBE26711AFB3F20005EA03 /* JSHTMLMeterElement.h in Headers */,
     19435                                A7BBE26711AFB3F20005EA03 /* JSHTMLMeterElement.h in Headers */,
    1943619436                                B6B0540A11B68F10002564C5 /* IDBObjectStoreImpl.h in Headers */,
    1943719437                        );
    … …  
    2173421734                                9FFE3E7A11B59C5D0037874E /* MemoryInfo.cpp in Sources */,
    2173521735                                9FFE3EA511B5A4390037874E /* JSMemoryInfo.cpp in Sources */,
    21736                                 A7BBE26611AFB3F20005EA03 /* JSHTMLMeterElement.cpp in Sources */,                               
     21736                                A7BBE26611AFB3F20005EA03 /* JSHTMLMeterElement.cpp in Sources */,
    2173721737                                B6B0540911B68F10002564C5 /* IDBObjectStoreImpl.cpp in Sources */,
    2173821738                        );

  • trunk/WebCore/html/HTML5Lexer.cpp

    r60826 r60827  
    10311031        else if (cc == '=')
    10321032            ADVANCE_TO(BeforeAttributeValueState);
    1033         else if (cc == '=')
     1033        else if (cc == '>')
    10341034            EMIT_AND_RESUME_IN(DataState);
    10351035        else if (cc >= 'A' && cc <= 'Z') {
Note: See TracChangeset for help on using the changeset viewer.