Changeset 60830 in webkit
- Timestamp:
- Jun 8, 2010 1:35:10 AM (14 years ago)
- Location:
- trunk/JavaScriptCore
- Files:
-
- 3 edited
- 2 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/JavaScriptCore/ChangeLog
r60820 r60830 1 2010-06-08 Kwang Yul Seo <skyul@company100.net> 2 3 Reviewed by Adam Barth. 4 5 Change OwnPtrCommon to include platform-specific headers 6 https://bugs.webkit.org/show_bug.cgi?id=40279 7 8 Adding new type to OwnPtrCommon needlessly causes all ports to do full rebuilds. 9 Change OwnPtrCommon to include platform-specific headers to avoid all ports rebuilds. 10 11 * JavaScriptCore.vcproj/WTF/WTF.vcproj: 12 * wtf/OwnPtrCommon.h: 13 * wtf/brew/OwnPtrBrew.h: Added. 14 * wtf/win/OwnPtrWin.h: Added. 15 1 16 2010-06-07 MORITA Hajime <morrita@google.com> 2 17 -
trunk/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj
r59187 r60830 244 244 > 245 245 </File> 246 <File 247 RelativePath="..\..\wtf\win\OwnPtrWin.h" 248 > 249 </File> 246 250 </Filter> 247 251 <File -
trunk/JavaScriptCore/wtf/OwnPtrCommon.h
r60787 r60830 29 29 #define WTF_OwnPtrCommon_h 30 30 31 #if PLATFORM(WIN)32 typedef struct HBITMAP__* HBITMAP;33 typedef struct HBRUSH__* HBRUSH;34 typedef struct HDC__* HDC;35 typedef struct HFONT__* HFONT;36 typedef struct HPALETTE__* HPALETTE;37 typedef struct HPEN__* HPEN;38 typedef struct HRGN__* HRGN;39 #endif40 41 #if PLATFORM(BREWMP)42 // Forward delcarations at this point avoid the need to include BREW includes43 // in WTF headers.44 typedef struct _ISocket ISocket;45 typedef struct _IFileMgr IFileMgr;46 typedef struct _IFile IFile;47 typedef struct IBitmap IBitmap;48 typedef struct ISSL ISSL;49 #endif50 51 31 namespace WTF { 52 32 … … 58 38 } 59 39 60 #if PLATFORM(WIN) 61 void deleteOwnedPtr(HBITMAP); 62 void deleteOwnedPtr(HBRUSH); 63 void deleteOwnedPtr(HDC); 64 void deleteOwnedPtr(HFONT); 65 void deleteOwnedPtr(HPALETTE); 66 void deleteOwnedPtr(HPEN); 67 void deleteOwnedPtr(HRGN); 40 } // namespace WTF 41 42 #if PLATFORM(BREWMP) 43 #include <wtf/brew/OwnPtrBrew.h> 44 #elif PLATFORM(WIN) 45 #include <wtf/win/OwnPtrWin.h> 68 46 #endif 69 47 70 #if PLATFORM(BREWMP)71 void deleteOwnedPtr(IFileMgr*);72 void deleteOwnedPtr(IFile*);73 void deleteOwnedPtr(IBitmap*);74 void deleteOwnedPtr(ISSL*);75 void deleteOwnedPtr(ISocket*);76 #endif77 78 } // namespace WTF79 80 48 #endif // WTF_OwnPtrCommon_h -
trunk/JavaScriptCore/wtf/brew/OwnPtrBrew.h
r60828 r60830 1 1 /* 2 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Torch Mobile, Inc. 4 * Copyright (C) 2010 Company 100 Inc. 2 * Copyright (C) 2010 Company 100 Inc. All rights reserved. 5 3 * 6 4 * Redistribution and use in source and binary forms, with or without … … 26 24 */ 27 25 28 #ifndef WTF_OwnPtrCommon_h29 #define WTF_OwnPtrCommon_h26 #ifndef OwnPtrBrew_h 27 #define OwnPtrBrew_h 30 28 31 #if PLATFORM(WIN)32 typedef struct HBITMAP__* HBITMAP;33 typedef struct HBRUSH__* HBRUSH;34 typedef struct HDC__* HDC;35 typedef struct HFONT__* HFONT;36 typedef struct HPALETTE__* HPALETTE;37 typedef struct HPEN__* HPEN;38 typedef struct HRGN__* HRGN;39 #endif40 41 #if PLATFORM(BREWMP)42 29 // Forward delcarations at this point avoid the need to include BREW includes 43 30 // in WTF headers. … … 47 34 typedef struct IBitmap IBitmap; 48 35 typedef struct ISSL ISSL; 49 #endif50 36 51 37 namespace WTF { 52 38 53 template <typename T> inline void deleteOwnedPtr(T* ptr) 54 { 55 typedef char known[sizeof(T) ? 1 : -1]; 56 if (sizeof(known)) 57 delete ptr; 58 } 59 60 #if PLATFORM(WIN) 61 void deleteOwnedPtr(HBITMAP); 62 void deleteOwnedPtr(HBRUSH); 63 void deleteOwnedPtr(HDC); 64 void deleteOwnedPtr(HFONT); 65 void deleteOwnedPtr(HPALETTE); 66 void deleteOwnedPtr(HPEN); 67 void deleteOwnedPtr(HRGN); 68 #endif 69 70 #if PLATFORM(BREWMP) 71 void deleteOwnedPtr(IFileMgr*); 72 void deleteOwnedPtr(IFile*); 73 void deleteOwnedPtr(IBitmap*); 74 void deleteOwnedPtr(ISSL*); 75 void deleteOwnedPtr(ISocket*); 76 #endif 39 void deleteOwnedPtr(IFileMgr*); 40 void deleteOwnedPtr(IFile*); 41 void deleteOwnedPtr(IBitmap*); 42 void deleteOwnedPtr(ISSL*); 43 void deleteOwnedPtr(ISocket*); 77 44 78 45 } // namespace WTF 79 46 80 #endif // WTF_OwnPtrCommon_h47 #endif // OwnPtrBrew_h -
trunk/JavaScriptCore/wtf/win/OwnPtrWin.h
r60828 r60830 1 1 /* 2 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Torch Mobile, Inc. 2 * Copyright (C) 2009 Torch Mobile, Inc. All rights reserved. 4 3 * Copyright (C) 2010 Company 100 Inc. 5 4 * … … 26 25 */ 27 26 28 #ifndef WTF_OwnPtrCommon_h29 #define WTF_OwnPtrCommon_h27 #ifndef OwnPtrWin_h 28 #define OwnPtrWin_h 30 29 31 #if PLATFORM(WIN)32 30 typedef struct HBITMAP__* HBITMAP; 33 31 typedef struct HBRUSH__* HBRUSH; … … 37 35 typedef struct HPEN__* HPEN; 38 36 typedef struct HRGN__* HRGN; 39 #endif40 41 #if PLATFORM(BREWMP)42 // Forward delcarations at this point avoid the need to include BREW includes43 // in WTF headers.44 typedef struct _ISocket ISocket;45 typedef struct _IFileMgr IFileMgr;46 typedef struct _IFile IFile;47 typedef struct IBitmap IBitmap;48 typedef struct ISSL ISSL;49 #endif50 37 51 38 namespace WTF { 52 39 53 template <typename T> inline void deleteOwnedPtr(T* ptr) 54 { 55 typedef char known[sizeof(T) ? 1 : -1]; 56 if (sizeof(known)) 57 delete ptr; 58 } 59 60 #if PLATFORM(WIN) 61 void deleteOwnedPtr(HBITMAP); 62 void deleteOwnedPtr(HBRUSH); 63 void deleteOwnedPtr(HDC); 64 void deleteOwnedPtr(HFONT); 65 void deleteOwnedPtr(HPALETTE); 66 void deleteOwnedPtr(HPEN); 67 void deleteOwnedPtr(HRGN); 68 #endif 69 70 #if PLATFORM(BREWMP) 71 void deleteOwnedPtr(IFileMgr*); 72 void deleteOwnedPtr(IFile*); 73 void deleteOwnedPtr(IBitmap*); 74 void deleteOwnedPtr(ISSL*); 75 void deleteOwnedPtr(ISocket*); 76 #endif 40 void deleteOwnedPtr(HBITMAP); 41 void deleteOwnedPtr(HBRUSH); 42 void deleteOwnedPtr(HDC); 43 void deleteOwnedPtr(HFONT); 44 void deleteOwnedPtr(HPALETTE); 45 void deleteOwnedPtr(HPEN); 46 void deleteOwnedPtr(HRGN); 77 47 78 48 } // namespace WTF 79 49 80 #endif // WTF_OwnPtrCommon_h50 #endif // OwnPtrWin_h
Note: See TracChangeset
for help on using the changeset viewer.