Changeset 60869 in webkit

Timestamp:

Jun 8, 2010 4:09:34 PM (14 years ago)

Author:

jchaffraix@webkit.org

Message:

[Qt] Crashfix on Path::contains
​https://bugs.webkit.org/show_bug.cgi?id=40253

Patch by Enrico Ros <​eros@codeaurora.org> on 2010-06-08
Reviewed by Ariya Hidayat.

Fix accessing the first item of an empty vector, that happens when
CanvasRenderingContext2D::isPointInPath is invoked over a borderless
path (e.g. a path made of just a MoveTo operation).

• platform/graphics/qt/PathQt.cpp:

(WebCore::isPointOnPathBorder):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/PathQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-08  Enrico Ros  <eros@codeaurora.org>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] Crashfix on Path::contains
+        https://bugs.webkit.org/show_bug.cgi?id=40253
+
+        Fix accessing the first item of an empty vector, that happens when
+        CanvasRenderingContext2D::isPointInPath is invoked over a borderless
+        path (e.g. a path made of just a MoveTo operation).
+
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::isPointOnPathBorder):
+
 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/platform/graphics/qt/PathQt.cpp

@@ -73 +73 @@
 bool isPointOnPathBorder(const QPolygonF& border, const QPointF& p)
 {
+    // null border doesn't contain points
+    if (border.isEmpty())
+        return false;
+
     QPointF p1 = border.at(0);
     QPointF p2;