Changeset 60899 in webkit


Ignore:
Timestamp:
Jun 9, 2010 10:12:01 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-06-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

LayoutTests needlessly depend on old parser quirks covered by other tests
​https://bugs.webkit.org/show_bug.cgi?id=40354

There are two quirks of the old HTMLTokenizer which I'm removing
from various tests in this change.

  • <tag<tag> parsing is a quirk unique to WebKit's old tokenizer and is already tested by fast/invalid/016.html and html5lib/runner.html.
  • <script/> is another quirk unique to WebKit's old tokenizer and is covered by fast/parser/script-tag-with-trailing-slash.html
  • fast/block/float/4145535Crash.html:
    • The test tests a CSS crasher. Changed the html to be explicit about how it should be parsed instead of depending on the <tag<tag> quirk of the old parser.
  • fast/dom/HTMLScriptElement/script-load-events.html:
    • Remove testing of <script/> since that's already covered by fast/parser/script-tag-with-trailing-slash.html
  • fast/dom/HTMLScriptElement/script-set-src-expected.txt:
    • Same as above.
  • fast/dom/HTMLScriptElement/script-set-src.html:
    • Same as above.
  • fast/events/pageshow-pagehide.html:
    • Remove dependence on <tag<tag> quirk.
  • fast/events/resources/pageshow-pagehide-subframe-cachable.html:
    • <tag<tag> quirk.
  • fast/events/resources/pageshow-pagehide-subframe.html:
    • <tag<tag> quirk.
  • fast/frames/sandboxed-iframe-navigation-parent.html:
    • <tag<tag> quirk.
  • fast/lists/w3-css3-list-styles-alphabetic.html:
    • <tag<tag> quirk.
  • fast/multicol/negativeColumnWidth.html:
    • <tag<tag> quirk.
  • fast/ruby/ruby-illegal-2.html:
    • The original fix (​https://trac.webkit.org/changeset/53525) was a fix to rendering code. I've simply corrected the test to be explicit about how it should be parsed so that it can test the rendering code path without depending on the <tag<tag> quirk of the old HTMLTokenizer.
  • fast/ruby/ruby-illegal-3.html:
    • Same as above.
  • http/tests/misc/generated-content-inside-table.html:
    • Remove dependence on the <script/> quirk.
  • svg/custom/svg-fonts-in-html-linebreaks.html:
    • <tag<tag> quirk.
Location:
trunk/LayoutTests
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r60890 r60899  
     12010-06-09  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        LayoutTests needlessly depend on old parser quirks covered by other tests
     6        https://bugs.webkit.org/show_bug.cgi?id=40354
     7
     8        There are two quirks of the old HTMLTokenizer which I'm removing
     9        from various tests in this change.
     10         - <tag<tag> parsing is a quirk unique to WebKit's old tokenizer
     11           and is already tested by fast/invalid/016.html and
     12           html5lib/runner.html.
     13         - <script/> is another quirk unique to WebKit's old tokenizer and
     14           is covered by fast/parser/script-tag-with-trailing-slash.html
     15
     16        * fast/block/float/4145535Crash.html:
     17         - The test tests a CSS crasher.  Changed the html to
     18           be explicit about how it should be parsed instead of
     19           depending on the <tag<tag> quirk of the old parser.
     20        * fast/dom/HTMLScriptElement/script-load-events.html:
     21         - Remove testing of <script/> since that's already covered
     22           by fast/parser/script-tag-with-trailing-slash.html
     23        * fast/dom/HTMLScriptElement/script-set-src-expected.txt:
     24         - Same as above.
     25        * fast/dom/HTMLScriptElement/script-set-src.html:
     26         - Same as above.
     27        * fast/events/pageshow-pagehide.html:
     28         - Remove dependence on <tag<tag> quirk.
     29        * fast/events/resources/pageshow-pagehide-subframe-cachable.html:
     30         - <tag<tag> quirk.
     31        * fast/events/resources/pageshow-pagehide-subframe.html:
     32         - <tag<tag> quirk.
     33        * fast/frames/sandboxed-iframe-navigation-parent.html:
     34         - <tag<tag> quirk.
     35        * fast/lists/w3-css3-list-styles-alphabetic.html:
     36         - <tag<tag> quirk.
     37        * fast/multicol/negativeColumnWidth.html:
     38         - <tag<tag> quirk.
     39        * fast/ruby/ruby-illegal-2.html:
     40         - The original fix (https://trac.webkit.org/changeset/53525) was
     41           a fix to rendering code.  I've simply corrected the test to be
     42           explicit about how it should be parsed so that it can test the
     43           rendering code path without depending on the <tag<tag> quirk
     44           of the old HTMLTokenizer.
     45        * fast/ruby/ruby-illegal-3.html:
     46         - Same as above.
     47        * http/tests/misc/generated-content-inside-table.html:
     48         - Remove dependence on the <script/> quirk.
     49        * svg/custom/svg-fonts-in-html-linebreaks.html:
     50         - <tag<tag> quirk.
     51
    1522010-06-09  Csaba Osztrogonác  <ossy@webkit.org>
    253

  • trunk/LayoutTests/fast/block/float/4145535Crash.html

    r11995 r60899  
    11<table
    2 CELLSPACING=8888888888
     2CELLSPACING=8888888888>
    33<EMBED UNITS="4">

  • trunk/LayoutTests/fast/dom/HTMLScriptElement/script-load-events.html

    r48891 r60899  
    2525    if (status_[2] != "L")
    2626        failures += "2 ";
    27     if (status_[3] != "L")
    28         failures += "3 ";
    2927    if (status_[4] != "L")
    3028        failures += "4 ";
    … …  
    6462<script type="text/javascript" onload="loaded(1)" onerror="erred(1)" src="resources/certainlydoesnotexist.js"></script>
    6563<script type="text/javascript" onload="loaded(2)" onerror="erred(2)" src="resources/script-load.js"></script>
    66 <script type="text/javascript" onload="loaded(3)" onerror="erred(3)" src="resources/script-load.js"/>
     64<!-- 3 was a self-closing script tag, however that is covered by fast/parser/script-tag-with-trailing-slash.html -->
    6765<script type="text/javascript">
    6866    document.write('<script type="text/javascript" onload="loaded(4)" onerror="erred(4)" src="resources/script-load.js"></script'+'>');

  • trunk/LayoutTests/fast/dom/HTMLScriptElement/script-set-src-expected.txt

    r21687 r60899  
    99No text and no source: PASS
    1010
    11 Self-closing <script> tag: PASS
    12 
    1311Using setAttribute: PASS
    1412

  • trunk/LayoutTests/fast/dom/HTMLScriptElement/script-set-src.html

    r42665 r60899  
    1717    document.getElementById("s5").src = "resources/script-set-src-p5fail.js";
    1818    document.getElementById("s3").src = "resources/script-set-src-p3pass.js";
    19     document.getElementById("s4").src = "resources/script-set-src-p4pass.js";
    2019    document.getElementById("s6").setAttribute("src", "resources/script-set-src-p6pass.js");
    2120   
    … …  
    4645<script type="text/javascript" id="s5" src="resources/script-set-src-p5pass.js"></script>
    4746<script type="text/javascript" id="s3"></script>
    48 <script type="text/javascript" id="s4"/>
     47<!-- s4 was a self-closing script tag, however that is covered by fast/parser/script-tag-with-trailing-slash.html -->
    4948<script type="text/javascript" id="s6"></script>
    5049</head>
    … …  
    5554<p>Already specifying valid source: <span id="p5">FAIL</span></p>
    5655<p>No text and no source: <span id="p3">FAIL</span></p>
    57 <p>Self-closing &lt;script&gt; tag: <span id="p4">FAIL</span></p>
    5856<p>Using setAttribute: <span id="p6">FAIL</span></p>
    5957<hr>

  • trunk/LayoutTests/fast/events/pageshow-pagehide.html

    r47824 r60899  
    11<p>Test pageshow/pagehide event behavior in subframes.</p>
    2 <iframe src="resources/pageshow-pagehide-subframe.html"</iframe>
    3 <pre id=log></pre>
     2<iframe src="resources/pageshow-pagehide-subframe.html"></iframe>
     3<pre id="log"></pre>
    44<script>
    55if (window.layoutTestController) {

  • trunk/LayoutTests/fast/events/resources/pageshow-pagehide-subframe-cachable.html

    r48036 r60899  
    11<body onpageshow='onPageshow(event)' onpagehide='onPagehide(event)'>
    22<p>Subframe</p>
    3 <iframe src="pageshow-pagehide-subsubframe-cachable.html"</iframe>
     3<iframe src="pageshow-pagehide-subsubframe-cachable.html"></iframe>
    44<script>
    55window.onload = function(evt) {

  • trunk/LayoutTests/fast/events/resources/pageshow-pagehide-subframe.html

    r47824 r60899  
    11<body onpageshow='onPageshow(event)' onpagehide='onPagehide(event)'>
    22<p>Subframe</p>
    3 <iframe src="pageshow-pagehide-subsubframe.html"</iframe>
     3<iframe src="pageshow-pagehide-subsubframe.html"></iframe>
    44<script>
    55window.onload = function(evt) {

  • trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-parent.html

    r51577 r60899  
    5454
    5555    <iframe name='navigated'
    56             src="resources/sandboxed-iframe-navigation-parent.html"
     56            src="resources/sandboxed-iframe-navigation-parent.html">
    5757    </iframe>
    5858

  • trunk/LayoutTests/fast/lists/w3-css3-list-styles-alphabetic.html

    r53452 r60899  
    11451145            <li>&#x1320;</li>
    11461146            <li>&#x1328;</li>
    1147             <li>&#x1338;</li
     1147            <li>&#x1338;</li>
    11481148        </ol>
    11491149        <ol class="tigre" start="25">
    … …  
    11811181            <li>&#x1320;</li>
    11821182            <li>&#x1328;</li>
    1183             <li>&#x1338;</li
     1183            <li>&#x1338;</li>
    11841184        </ol>
    11851185        <ol class="ethiopic-halehame-tig" start="25">
    … …  
    12141214            <li>&#x12C8;</li>
    12151215            <li>&#x12D0;</li>
    1216             <li>&#x12D8;</li
     1216            <li>&#x12D8;</li>
    12171217        </ol>
    12181218        <ol class="tigrinya-er" start="21">
    … …  
    12561256            <li>&#x12C8;</li>
    12571257            <li>&#x12D0;</li>
    1258             <li>&#x12D8;</li
     1258            <li>&#x12D8;</li>
    12591259        </ol>
    12601260        <ol class="ethiopic-halehame-ti-er" start="21">

  • trunk/LayoutTests/fast/multicol/negativeColumnWidth.html

    r47510 r60899  
    11This test succeeds if it does not crash.
    22
    3 <table<td style="-webkit-columns: -9999px;">
     3<table><td style="-webkit-columns: -9999px;">
    44
    55<script>

  • trunk/LayoutTests/fast/ruby/ruby-illegal-2.html

    r53525 r60899  
    1313<div id="result">FAILED!</div>
    1414<!-- The following malformed (!) line mustn't crash the renderer -->
    15 <ruby <table >\x0e
     15<ruby><table>\x0e
    1616</body>
    1717</html>

  • trunk/LayoutTests/fast/ruby/ruby-illegal-3.html

    r53525 r60899  
    1313<div id="result">FAILED!</div>
    1414<!-- The following malformed (!) line mustn't crash the renderer -->
    15 <ruby <table >\x0f<i
     15<ruby><table>\x0f<i>
    1616</body>
    1717</html>

  • trunk/LayoutTests/http/tests/misc/generated-content-inside-table.html

    r41865 r60899  
    1111    <tr>
    1212        <td>
    13             <script type="text/javascript" src="resources/script-slow1.pl" />
     13            <script type="text/javascript" src="resources/script-slow1.pl"></script>
    1414            <div id="bad">
    1515                This text should not break

  • trunk/LayoutTests/svg/custom/svg-fonts-in-html-linebreaks.html

    r52525 r60899  
    6060</div>
    6161<br>
    62 <div>As a reference, this is how normal text looks like for the same usecase:</div
     62<div>As a reference, this is how normal text looks like for the same usecase:</div>
    6363<br>
    6464<div>
Note: See TracChangeset for help on using the changeset viewer.