Changeset 60910 in webkit

Timestamp:

Jun 9, 2010 1:53:30 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-06-09 Anders Bakken <​agbakken@gmail.com>

Reviewed by David Levin.

[Qt] ChromeClientQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40240

• WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::print): (WebCore::ChromeClientQt::attachRootGraphicsLayer): (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientQt.cpp (modified) (12 diffs)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-06-09  Anders Bakken  <agbakken@gmail.com>
+
+        Reviewed by David Levin.
+
+        [Qt] ChromeClientQt.cpp has coding-style errors
+        https://bugs.webkit.org/show_bug.cgi?id=40240
+
+        * WebCoreSupport/ChromeClientQt.cpp:
+        (WebCore::ChromeClientQt::pageRect):
+        (WebCore::ChromeClientQt::createWindow):
+        (WebCore::ChromeClientQt::runJavaScriptAlert):
+        (WebCore::ChromeClientQt::runJavaScriptConfirm):
+        (WebCore::ChromeClientQt::runJavaScriptPrompt):
+        (WebCore::ChromeClientQt::print):
+        (WebCore::ChromeClientQt::attachRootGraphicsLayer):
+        (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):
+
 2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

@@ -30 +30 @@
 #include "ChromeClientQt.h"
 
+#include "DatabaseTracker.h"
 #include "FileChooser.h"
 #include "Frame.h"
@@ -38 +39 @@
 #include "HitTestResult.h"
 #include "Icon.h"
+#include "NotImplemented.h"
 #include "NotificationPresenterClientQt.h"
-#include "NotImplemented.h"
 #include "ScrollbarTheme.h"
 #include "WindowFeatures.h"
-#include "DatabaseTracker.h"
 #if defined(Q_WS_MAEMO_5)
 #include "QtMaemoWebPopup.h"
@@ -51 +51 @@
 #include "SecurityOrigin.h"
 
+#include "qwebframe_p.h"
+#include "qwebpage.h"
+#include "qwebpage_p.h"
+#include "qwebsecurityorigin.h"
+#include "qwebsecurityorigin_p.h"
+#include "qwebview.h"
+
 #include <qdebug.h>
 #include <qeventloop.h>
@@ -56 +63 @@
 #include <qtooltip.h>
 
-#include "qwebpage.h"
-#include "qwebpage_p.h"
-#include "qwebframe_p.h"
-#include "qwebsecurityorigin.h"
-#include "qwebsecurityorigin_p.h"
-#include "qwebview.h"
-
 #if USE(ACCELERATED_COMPOSITING)
 #include "GraphicsLayerQt.h"
@@ -107 +107 @@
     if (!m_webPage)
         return FloatRect();
-    return FloatRect(QRectF(QPointF(0,0), m_webPage->viewportSize()));
+    return FloatRect(QRectF(QPointF(0, 0), m_webPage->viewportSize()));
 }
 
@@ -164 +164 @@
 Page* ChromeClientQt::createWindow(Frame*, const FrameLoadRequest& request, const WindowFeatures& features)
 {
-    QWebPage *newPage = m_webPage->createWindow(features.dialog ? QWebPage::WebModalDialog : QWebPage::WebBrowserWindow);
+    QWebPage* newPage = m_webPage->createWindow(features.dialog ? QWebPage::WebModalDialog : QWebPage::WebBrowserWindow);
     if (!newPage)
         return 0;
@@ -291 +291 @@
 {
     QString x = msg;
-    FrameLoaderClientQt *fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
+    FrameLoaderClientQt* fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
     m_webPage->javaScriptAlert(fl->webFrame(), x);
 }
@@ -298 +298 @@
 {
     QString x = msg;
-    FrameLoaderClientQt *fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
+    FrameLoaderClientQt* fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
     return m_webPage->javaScriptConfirm(fl->webFrame(), x);
 }
@@ -305 +305 @@
 {
     QString x = result;
-    FrameLoaderClientQt *fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
+    FrameLoaderClientQt* fl = static_cast<FrameLoaderClientQt*>(f->loader()->client());
     bool rc = m_webPage->javaScriptPrompt(fl->webFrame(), (QString)message, (QString)defaultValue, &x);
 
@@ -460 +460 @@
 }
 
-void ChromeClientQt::print(Frame *frame)
+void ChromeClientQt::print(Frame* frame)
 {
     emit m_webPage->printRequested(QWebFramePrivate::kit(frame));
@@ -543 +543 @@
 #if USE(ACCELERATED_COMPOSITING)
 void ChromeClientQt::attachRootGraphicsLayer(Frame* frame, GraphicsLayer* graphicsLayer)
-{    
+{
     if (platformPageClient())
         platformPageClient()->setRootGraphicsLayer(graphicsLayer ? graphicsLayer->nativeLayer() : 0);
@@ -568 +568 @@
 
 #endif
-    
+
 #if ENABLE(TILED_BACKING_STORE)
 IntRect ChromeClientQt::visibleRectForTiledBackingStore() const
-{ 
+{
     if (!platformPageClient() || !m_webPage)
         return IntRect();