Changeset 60921 in webkit


Ignore:
Timestamp:
Jun 9, 2010 3:55:11 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-06-09 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

[Qt] EditCommandQt.cpp/h have coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40248

  • WebCoreSupport/EditCommandQt.cpp: (EditCommandQt::EditCommandQt): (EditCommandQt::~EditCommandQt): (EditCommandQt::redo): (EditCommandQt::undo):
  • WebCoreSupport/EditCommandQt.h:
Location:
trunk/WebKit/qt
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/qt/ChangeLog

    r60917 r60921  
     12010-06-09  Anders Bakken  <agbakken@gmail.com>
     2
     3        Reviewed by David Levin.
     4
     5        [Qt] EditCommandQt.cpp/h have coding-style errors
     6        https://bugs.webkit.org/show_bug.cgi?id=40248
     7
     8        * WebCoreSupport/EditCommandQt.cpp:
     9        (EditCommandQt::EditCommandQt):
     10        (EditCommandQt::~EditCommandQt):
     11        (EditCommandQt::redo):
     12        (EditCommandQt::undo):
     13        * WebCoreSupport/EditCommandQt.h:
     14
    1152010-06-09  Anders Bakken  <agbakken@gmail.com>
    216
  • trunk/WebKit/qt/WebCoreSupport/EditCommandQt.cpp

    r55633 r60921  
    2828    QUndoCommand(parent),
    2929#endif
    30     _cmd(cmd), _first(true)
     30    m_cmd(cmd), m_first(true)
    3131{
    3232}
    3333
    3434
    35 EditCommandQt::~EditCommandQt() {
     35EditCommandQt::~EditCommandQt()
     36{
    3637}
    3738
    3839
    39 void EditCommandQt::redo() {
    40     if (_first) {
    41         _first = false;
     40void EditCommandQt::redo()
     41{
     42    if (m_first) {
     43        m_first = false;
    4244        return;
    4345    }
    44     if (_cmd) {
    45         _cmd->reapply();
    46     }
     46    if (m_cmd)
     47        m_cmd->reapply();
    4748}
    4849
    4950
    50 void EditCommandQt::undo() {
    51     if (_cmd) {
    52         _cmd->unapply();
    53     }
     51void EditCommandQt::undo()
     52{
     53    if (m_cmd)
     54        m_cmd->unapply();
    5455}
    5556
  • trunk/WebKit/qt/WebCoreSupport/EditCommandQt.h

    r37409 r60921  
    1818*/
    1919
    20 #ifndef EDITCOMMANDQT_H
    21 #define EDITCOMMANDQT_H
     20#ifndef EditCommandQt_h
     21#define EditCommandQt_h
    2222
     23#include <EditCommand.h>
     24#include <QUndoCommand>
    2325#include <qglobal.h>
    24 QT_BEGIN_NAMESPACE
    25 class QUndoCommand;
    26 QT_END_NAMESPACE
    27 
    28 #include <QUndoCommand>
    29 #include <EditCommand.h>
    3026
    3127class EditCommandQt
     
    4238
    4339    private:
    44         WTF::RefPtr<WebCore::EditCommand> _cmd;
    45         bool _first;
     40        WTF::RefPtr<WebCore::EditCommand> m_cmd;
     41        bool m_first;
    4642};
    4743
Note: See TracChangeset for help on using the changeset viewer.