Changeset 60938 in webkit

Timestamp:

Jun 9, 2010 10:38:32 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-06-09 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

webkit-patch upload fails for security bugs because there's no rietveld flag
​https://bugs.webkit.org/show_bug.cgi?id=40309

There's probably a more elegant way of seeing whether the form control
exists, but this seems to work.

• Scripts/webkitpy/common/net/bugzilla.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-06-09  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Ojan Vafai.
+
+        webkit-patch upload fails for security bugs because there's no rietveld flag
+        https://bugs.webkit.org/show_bug.cgi?id=40309
+
+        There's probably a more elegant way of seeing whether the form control
+        exists, but this seems to work.
+
+        * Scripts/webkitpy/common/net/bugzilla.py:
+
 2010-06-09  Ojan Vafai  <ojan@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py

@@ -639 +639 @@
             self.browser['flag_type-3'] = ('X',)
 
-        # Add all patches to the rietveld upload queue.
-        self.browser['flag_type-4'] = ('?',)
+        try:
+            # Add all patches to the rietveld upload queue.
+            self.browser['flag_type-4'] = ('?',)
+        except ControlNotFoundError, e:
+            pass  # If there is no rietveld flag, we can't set it.
 
         if bug_id: