Changeset 60944 in webkit


Ignore:
Timestamp:
Jun 10, 2010 1:35:13 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
​https://bugs.webkit.org/show_bug.cgi?id=40262

See comment in opacity-change-on-overflow-float.html to understand why
we made this goofy change.

  • fast/repaint/opacity-change-on-overflow-float.html:
  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
  • platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:
Location:
trunk/LayoutTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r60939 r60944  
     12010-06-10  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
     6        https://bugs.webkit.org/show_bug.cgi?id=40262
     7
     8        See comment in opacity-change-on-overflow-float.html to understand why
     9        we made this goofy change.
     10
     11        * fast/repaint/opacity-change-on-overflow-float.html:
     12        * html5lib/resources/webkit01.dat:
     13        * html5lib/runner-expected.txt:
     14        * html5lib/webkit-resumer-expected.txt:
     15        * platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
     16        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:
     17
    1182010-06-09  Alexey Proskuryakov  <ap@apple.com>
    219

  • trunk/LayoutTests/fast/repaint/opacity-change-on-overflow-float.html

    r43817 r60944  
    2828</head>
    2929<body onload="runRepaintTest()">
    30 <p>Repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.  Make sure when a layer switches
     30<p>Repaint test for <rdar><!--
     31Oh man, let me explain why this is here.  In the beginning, there was an
     32<rdar:://problem/6869687> link to the great and mysterious rdar.  However, that
     33link was invisible because whoever added it decided to enclose the link in
     34angle brackets.
     35
     36There was peace in the land, until we implemented the HTML5 parsing algorithm,
     37which changed the name of the mysterious rdar element to not include //
     38charaters.  Rather than regenerate the expected results (which were platform
     39specific), our hero changed the rdar link to an <rdar> element and hand-edited
     40the expected render tree.
     41
     42And on the third day, he rested. --> REGRESSION (r41203): Facebook friend suggestions disappear on update.  Make sure when a layer switches
    3143from being self-painting to non-self-painting that a layout happens to fix up the floating objects lists.  You should see a 100x100 green square below.
    3244If you see any red, the test has failed.

  • trunk/LayoutTests/html5lib/resources/webkit01.dat

    r60900 r60944  
    189189|       "Test"
    190190|       "Test2"
     191
     192#data
     193<rdar://problem/6869687>
     194#errors
     195#document
     196| <html>
     197|   <head>
     198|   <body>
     199|     <rdar:>
     200|       6869687=""
     201|       problem=""

  • trunk/LayoutTests/html5lib/runner-expected.txt

    r60900 r60944  
    40140113
    40240215
     40316
    403404
    404405resources/doctype01.dat:

  • trunk/LayoutTests/html5lib/webkit-resumer-expected.txt

    r60900 r60944  
    186186568.20
    187187569.21
     188570.1
     189571.2
     190572.3
     191573.4
     192574.5
     193575.6
     194576.7
     195577.8
     196578.9
     197579.10
     198580.11
     199581.12
     200582.13
     201583.14
     202584.15
     203585.16
     204586.17
     205587.18
     206588.19
     207589.20
     208590.21
     209591.22
     210592.23

  • trunk/LayoutTests/platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt

    r56268 r60944  
    77        RenderText {#text} at (0,0) size 96x19
    88          text run at (0,0) width 96: "Repaint test for "
    9         RenderInline {RDAR://PROBLEM/6869687} at (0,0) size 765x59
     9        RenderInline {RDAR} at (0,0) size 765x59
    1010          RenderText {#text} at (96,0) size 765x59
    1111            text run at (96,0) width 469: "REGRESSION (r41203): Facebook friend suggestions disappear on update. "

  • trunk/LayoutTests/platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt

    r43657 r60944  
    77        RenderText {#text} at (0,0) size 100x18
    88          text run at (0,0) width 100: "Repaint test for "
    9         RenderInline {RDAR://PROBLEM/6869687} at (0,0) size 763x54
     9        RenderInline {RDAR} at (0,0) size 763x54
    1010          RenderText {#text} at (100,0) size 763x54
    1111            text run at (100,0) width 486: "REGRESSION (r41203): Facebook friend suggestions disappear on update. "
Note: See TracChangeset for help on using the changeset viewer.