Changeset 61052 in webkit

Timestamp:

Jun 11, 2010 6:28:18 PM (14 years ago)

Author:

mjs@apple.com

Message:

2010-06-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Ojan Vafai.

Implement HTML5 hidden attribute
​https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

Note: I used the mapped attribute mechanism for this instead of a rule in the UA stylesheet
to avoid a performance hit from adding a global attribute rule to the UA stylesheet.

• html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.

2010-06-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Ojan Vafai.

Implement HTML5 hidden attribute
​https://bugs.webkit.org/show_bug.cgi?id=40511

• fast/html/hidden-attr-expected.txt: Added.
• fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/html/hidden-attr-expected.txt (added)
• LayoutTests/fast/html/hidden-attr.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-11  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Ojan Vafai.
+
+        Implement HTML5 hidden attribute
+        https://bugs.webkit.org/show_bug.cgi?id=40511
+
+        * fast/html/hidden-attr-expected.txt: Added.
+        * fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.
+
 2010-06-11  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-11  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Ojan Vafai.
+
+        Implement HTML5 hidden attribute
+        https://bugs.webkit.org/show_bug.cgi?id=40511
+
+        Test: fast/html/hidden-attr.html
+        
+        Note: I used the mapped attribute mechanism for this instead of a rule in the UA stylesheet
+        to avoid a performance hit from adding a global attribute rule to the UA stylesheet.
+
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute.
+        (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
+
 2010-06-10  Abhishek Arya  <inferno@chromium.org>
 

trunk/WebCore/html/HTMLElement.cpp

@@ -130 +130 @@
 bool HTMLElement::mapToEntry(const QualifiedName& attrName, MappedAttributeEntry& result) const
 {
-    if (attrName == alignAttr ||
-        attrName == contenteditableAttr) {
+    if (attrName == alignAttr
+        || attrName == contenteditableAttr
+        || attrName == hiddenAttr) {
         result = eUniversal;
         return false;
@@ -154 +155 @@
         else
             addCSSProperty(attr, CSSPropertyTextAlign, attr->value());
+    } else if (attr->name() == hiddenAttr) {
+        addCSSProperty(attr, CSSPropertyDisplay, CSSValueNone);
     } else if (attr->name() == contenteditableAttr) {
         setContentEditable(attr);