Changeset 61059 in webkit


Ignore:
Timestamp:
Jun 12, 2010 4:19:02 AM (14 years ago)
Author:
tkent@chromium.org
Message:

Disable interactive form validation in non-strict modes
https://bugs.webkit.org/show_bug.cgi?id=40218

Reviewed by Dimitri Glazkov.

WebCore:

The interactive validation feature of HTML5 is not compatible with
HTML4, and users and page authors don't expect existing sites work
differently in WebKit. For example, maxlength and required attributes
in existing sites unexpectedly prevented form submission.
So, we disable the interactive validation feature in non-strict
modes to improve compatibility.

Test: fast/forms/interactive-validation-compat-mode.html

fast/forms/interactive-validation-html4.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Process interactive validation only in the strict mode.

LayoutTests:

  • fast/forms/interactive-validation-compat-mode-expected.txt: Added.
  • fast/forms/interactive-validation-compat-mode.html: Added.
  • fast/forms/interactive-validation-html4-expected.txt: Added.
  • fast/forms/interactive-validation-html4.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r61056 r61059  
     12010-06-12  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Disable interactive form validation in non-strict modes
     6        https://bugs.webkit.org/show_bug.cgi?id=40218
     7
     8        * fast/forms/interactive-validation-compat-mode-expected.txt: Added.
     9        * fast/forms/interactive-validation-compat-mode.html: Added.
     10        * fast/forms/interactive-validation-html4-expected.txt: Added.
     11        * fast/forms/interactive-validation-html4.html: Added.
     12
    1132010-06-12  Robert Hogan  <robert@webkit.org>
    214
  • trunk/WebCore/ChangeLog

    r61057 r61059  
     12010-06-12  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Disable interactive form validation in non-strict modes
     6        https://bugs.webkit.org/show_bug.cgi?id=40218
     7
     8        The interactive validation feature of HTML5 is not compatible with
     9        HTML4, and users and page authors don't expect existing sites work
     10        differently in WebKit. For example, maxlength and required attributes
     11        in existing sites unexpectedly prevented form submission.
     12        So, we disable the interactive validation feature in non-strict
     13        modes to improve compatibility.
     14
     15        Test: fast/forms/interactive-validation-compat-mode.html
     16              fast/forms/interactive-validation-html4.html
     17
     18        * html/HTMLFormElement.cpp:
     19        (WebCore::HTMLFormElement::validateInteractively):
     20         Process interactive validation only in the strict mode.
     21
    1222010-06-12  Eric Seidel  <eric@webkit.org>
    223
  • trunk/WebCore/html/HTMLFormElement.cpp

    r60799 r61059  
    235235{
    236236    ASSERT(event);
    237     if (noValidate())
     237    if (!document()->inStrictMode() || noValidate())
    238238        return true;
    239239
Note: See TracChangeset for help on using the changeset viewer.