Changeset 61124 in webkit

Timestamp:

Jun 14, 2010 8:13:33 AM (14 years ago)

Author:

loislo@chromium.org

Message:

2010-06-14 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

• WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/InspectorClientGtk.cpp (modified) (1 diff)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-06-14  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Unreviewed build fix.
+
+        This is a fix for flaky inspector tests at gtk-debug bots.
+
+        * WebCoreSupport/InspectorClientGtk.cpp:
+        (WebKit::InspectorFrontendClient::destroyInspectorWindow):
+
 2010-06-14  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp

@@ -176 +176 @@
     core(m_inspectedWebView)->inspectorController()->disconnectFrontend();
 
+    if (m_inspectorClient)
+        m_inspectorClient->releaseFrontendPage();
+
     gboolean handled = FALSE;
     g_signal_emit_by_name(webInspector, "close-window", &handled);
     ASSERT(handled);
 
-    if (m_inspectorClient)
-        m_inspectorClient->releaseFrontendPage();
+    // Please do not use member variables here because InspectorFrontendClient object pointed by 'this'
+    // has been implicitly deleted by "close-window" function.
 
     /* we should now dispose our own reference */