Changeset 61278 in webkit


Ignore:
Timestamp:
Jun 16, 2010 1:28:58 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-06-16 Drew Wilson <​atwilson@chromium.org>

Reviewed by Kent Tamura.

Added plumbing to Chromium WebKit API to allow setting/getting the name
of top level frames.

​https://bugs.webkit.org/show_bug.cgi?id=40430

  • public/WebFrame.h: Added setName() API.
  • public/WebViewClient.h: (WebKit::WebViewClient::createView): Now takes a "name" parameter.
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow): Passes a name parameter.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setName): Allows setting the frame name by calling through to the WebCore API.
  • src/WebFrameImpl.h:

2010-06-16 Drew Wilson <​atwilson@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Plumbing for top-level frame names
​https://bugs.webkit.org/show_bug.cgi?id=40430

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Migrate to new createView() API.
  • DumpRenderTree/chromium/WebViewHost.h: Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r61217 r61278  
     12010-06-16  Drew Wilson  <atwilson@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Added plumbing to Chromium WebKit API to allow setting/getting the name
     6        of top level frames.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=40430
     9        * public/WebFrame.h:
     10        Added setName() API.
     11        * public/WebViewClient.h:
     12        (WebKit::WebViewClient::createView):
     13        Now takes a "name" parameter.
     14        * src/ChromeClientImpl.cpp:
     15        (WebKit::ChromeClientImpl::createWindow):
     16        Passes a name parameter.
     17        * src/WebFrameImpl.cpp:
     18        (WebKit::WebFrameImpl::setName):
     19        Allows setting the frame name by calling through to the WebCore API.
     20        * src/WebFrameImpl.h:
     21
    1222010-06-15  Darin Adler  <darin@apple.com>
    223

  • trunk/WebKit/chromium/public/WebFrame.h

    r59029 r61278  
    104104    virtual WebString name() const = 0;
    105105    virtual void clearName() = 0;
     106    virtual void setName(const WebString&) = 0;
    106107
    107108    // The url of the document loaded in this frame.  This is equivalent to

  • trunk/WebKit/chromium/public/WebViewClient.h

    r60985 r61278  
    7474    // WebStorage specification.
    7575    virtual WebView* createView(WebFrame* creator,
    76                                 const WebWindowFeatures& features) { return 0; }
     76                                const WebWindowFeatures& features,
     77                                const WebString& name) { return 0; }
    7778
    7879    // Create a new WebPopupMenu.  In the second form, the client is

  • trunk/WebKit/chromium/src/ChromeClientImpl.cpp

    r61097 r61278  
    232232
    233233    WebViewImpl* newView = static_cast<WebViewImpl*>(
    234         m_webView->client()->createView(WebFrameImpl::fromFrame(frame), features));
     234        m_webView->client()->createView(WebFrameImpl::fromFrame(frame), features, r.frameName()));
    235235    if (!newView)
    236236        return 0;

  • trunk/WebKit/chromium/src/WebFrameImpl.cpp

    r60463 r61278  
    478478}
    479479
     480void WebFrameImpl::setName(const WebString& name)
     481{
     482    m_frame->tree()->setName(name);
     483}
     484
    480485WebURL WebFrameImpl::url() const
    481486{

  • trunk/WebKit/chromium/src/WebFrameImpl.h

    r59524 r61278  
    6666    virtual WebString name() const;
    6767    virtual void clearName();
     68    virtual void setName(const WebString&);
    6869    virtual WebURL url() const;
    6970    virtual WebURL favIconURL() const;

  • trunk/WebKitTools/ChangeLog

    r61276 r61278  
     12010-06-16  Drew Wilson  <atwilson@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [Chromium] Plumbing for top-level frame names
     6        https://bugs.webkit.org/show_bug.cgi?id=40430
     7
     8        * DumpRenderTree/chromium/WebViewHost.cpp:
     9        (WebViewHost::createView):
     10        Migrate to new createView() API.
     11        * DumpRenderTree/chromium/WebViewHost.h:
     12        Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
     13
    1142010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
    215

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp

    r60218 r61278  
    254254// WebViewClient -------------------------------------------------------------
    255255
    256 WebView* WebViewHost::createView(WebFrame* creator)
    257 {
    258     return createView(creator, WebWindowFeatures());
    259 }
    260 
    261 WebView* WebViewHost::createView(WebFrame*, const WebWindowFeatures&)
     256WebView* WebViewHost::createView(WebFrame*, const WebWindowFeatures&, const WebString&)
    262257{
    263258    if (!layoutTestController()->canOpenWindows())

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.h

    r60032 r61278  
    9191
    9292    // WebKit::WebViewClient
    93     virtual WebKit::WebView* createView(WebKit::WebFrame*);
    94     virtual WebKit::WebView* createView(WebKit::WebFrame*, const WebKit::WebWindowFeatures&);
     93    virtual WebKit::WebView* createView(WebKit::WebFrame*, const WebKit::WebWindowFeatures&, const WebKit::WebString&);
    9594    virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType);
    9695    virtual WebKit::WebWidget* createPopupMenu(const WebKit::WebPopupMenuInfo&);
Note: See TracChangeset for help on using the changeset viewer.