Changeset 61291 in webkit

Timestamp:

Jun 16, 2010 3:58:04 PM (14 years ago)

Author:

Martin Robinson

Message:

2010-06-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
​https://bugs.webkit.org/show_bug.cgi?id=40269

• platform/gtk/Skipped: Unskip test which is now passing.

2010-06-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
​https://bugs.webkit.org/show_bug.cgi?id=40269

Only queue events while the mouse button is down, if drag mode is enabled. Some
tests may disable drag mode, to prevent the queuing of events in this situation.

• DumpRenderTree/gtk/EventSender.cpp: (sendOrQueueEvent): Only queue events here if dragMode is true.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/EventSender.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-16  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] r60803 broke media/controls-drag-timebar.html
+        https://bugs.webkit.org/show_bug.cgi?id=40269
+
+        * platform/gtk/Skipped: Unskip test which is now passing.
+
 2010-06-16  Adam Roben  <aroben@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5912 +5912 @@
 fast/dom/Geolocation/callback-to-deleted-context.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=40269
-media/controls-drag-timebar.html
-
 # GTK+ theme-rendered widgets do not support CSS transforms
 # https://bugs.webkit.org/show_bug.cgi?id=40139

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-06-16  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] r60803 broke media/controls-drag-timebar.html
+        https://bugs.webkit.org/show_bug.cgi?id=40269
+
+        Only queue events while the mouse button is down, if drag mode is enabled. Some
+        tests may disable drag mode, to prevent the queuing of events in this situation.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (sendOrQueueEvent): Only queue events here if dragMode is true.
+
 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
 

trunk/WebKitTools/DumpRenderTree/gtk/EventSender.cpp

@@ -346 +346 @@
     // Mouse move events are queued if the previous event was queued or if a
     // delay was set up by leapForward().
-    if (buttonCurrentlyDown || endOfQueue != startOfQueue || msgQueue[endOfQueue].delay) {
+    if ((dragMode && buttonCurrentlyDown) || endOfQueue != startOfQueue || msgQueue[endOfQueue].delay) {
         msgQueue[endOfQueue++].event = event;