Changeset 61346 in webkit


Ignore:
Timestamp:
Jun 17, 2010 1:39:04 PM (14 years ago)
Author:
robert@webkit.org
Message:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r61345 r61346  
     12010-06-17  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        [Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
     6
     7        Capture logDestroy messages from the test plugin. DRT's WebPage
     8        is already destroyed by the time they are emitted.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=33333
     11
     12        Unskip:
     13        plugins/open-and-close-window-with-plugin.html
     14        plugins/geturlnotify-during-document-teardown.html
     15
     16        * platform/qt/Skipped:
     17
    1182010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>
    219
  • trunk/LayoutTests/platform/qt/Skipped

    r61315 r61346  
    423423# ---- https://bugs.webkit.org/show_bug.cgi?id=36721
    424424plugins/get-url-with-blank-target.html
    425 
    426 # plugin logdestroy message reaches destroyed webpage
    427 # ---- https://bugs.webkit.org/show_bug.cgi?id=33333
    428 plugins/open-and-close-window-with-plugin.html
    429 plugins/geturlnotify-during-document-teardown.html
    430425
    431426# ---- https://bugs.webkit.org/show_bug.cgi?id=36702
  • trunk/WebKit/qt/Api/qwebpage.cpp

    r61342 r61346  
    19991999void QWebPage::javaScriptConsoleMessage(const QString& message, int lineNumber, const QString& sourceID)
    20002000{
    2001     Q_UNUSED(message)
    2002     Q_UNUSED(lineNumber)
    20032001    Q_UNUSED(sourceID)
     2002
     2003    // Catch plugin logDestroy message for LayoutTests/plugins/open-and-close-window-with-plugin.html
     2004    // At this point DRT's WebPage has already been destroyed
     2005    if (QWebPagePrivate::drtRun)
     2006        fprintf (stdout, "CONSOLE MESSAGE: line %d: %s\n", lineNumber, message.toUtf8().constData());
    20042007}
    20052008
  • trunk/WebKit/qt/ChangeLog

    r61342 r61346  
     12010-06-17  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        [Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
     6
     7        Capture logDestroy messages from the test plugin. DRT's WebPage
     8        is already destroyed by the time they are emitted.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=33333
     11
     12        Unskip:
     13        plugins/open-and-close-window-with-plugin.html
     14        plugins/geturlnotify-during-document-teardown.html
     15
     16        * Api/qwebpage.cpp:
     17        (QWebPage::javaScriptConsoleMessage):
     18
    1192010-06-17  Jesus Sanchez-Palencia  <jesus@webkit.org>, Kenneth Rohde Christiansen  <kenneth@webkit.org>
    220
Note: See TracChangeset for help on using the changeset viewer.