Changeset 61458 in webkit


Ignore:
Timestamp:
Jun 18, 2010 5:15:52 PM (14 years ago)
Author:
atwilson@chromium.org
Message:

[Chromium] Plumbing for top-level frame names
​https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

  • public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

  • src/WebFrameImpl.cpp:

Removed clearName() API.

  • src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r61417 r61458  
     12010-06-18  Drew Wilson  <atwilson@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [Chromium] Plumbing for top-level frame names
     6        https://bugs.webkit.org/show_bug.cgi?id=40430
     7
     8        * public/WebFrame.h:
     9        Removed obsolete clearName() API and added better documentation for
     10        setName().
     11        * src/WebFrameImpl.cpp:
     12        Removed clearName() API.
     13        * src/WebFrameImpl.h:
     14        Removed clearName() API.
     15
    1162010-06-18  Drew Wilson  <atwilson@chromium.org>
    217

  • trunk/WebKit/chromium/public/WebFrame.h

    r61278 r61458  
    103103    // The name of this frame.
    104104    virtual WebString name() const = 0;
    105     virtual void clearName() = 0;
     105
     106    // Sets the name of this frame. For child frames (frames that are not a
     107    // top-most frame) the actual name may have a suffix appended to make the
     108    // frame name unique within the hierarchy.
    106109    virtual void setName(const WebString&) = 0;
    107110

  • trunk/WebKit/chromium/src/WebFrameImpl.cpp

    r61278 r61458  
    473473}
    474474
    475 void WebFrameImpl::clearName()
    476 {
    477     m_frame->tree()->clearName();
    478 }
    479 
    480475void WebFrameImpl::setName(const WebString& name)
    481476{

  • trunk/WebKit/chromium/src/WebFrameImpl.h

    r61278 r61458  
    6565    // WebFrame methods:
    6666    virtual WebString name() const;
    67     virtual void clearName();
    6867    virtual void setName(const WebString&);
    6968    virtual WebURL url() const;

  • trunk/WebKitTools/ChangeLog

    r61443 r61458  
     12010-06-18  Drew Wilson  <atwilson@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [Chromium] Plumbing for top-level frame names
     6        https://bugs.webkit.org/show_bug.cgi?id=40430
     7
     8        * DumpRenderTree/chromium/WebViewHost.cpp:
     9        (WebViewHost::reset):
     10        Changed obsolete call to clearName() to use setName(WebString()) instead.
     11
    1122010-06-18  Sam Weinig  <weinig@apple.com>
    213

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp

    r61308 r61458  
    10321032    new (this) WebViewHost(shell);
    10331033    setWebWidget(widget);
    1034     webView()->mainFrame()->clearName();
     1034    webView()->mainFrame()->setName(WebString());
    10351035}
    10361036
Note: See TracChangeset for help on using the changeset viewer.