Changeset 61506 in webkit

Timestamp:

Jun 20, 2010 10:02:12 AM (14 years ago)

Author:

Joseph Pecoraro

Message:

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
​https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

• inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/InjectedScript.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: Should Autocomplete Style Properties
+        https://bugs.webkit.org/show_bug.cgi?id=38448
+
+        This Autocompletes style properties when in the console.
+
+        * inspector/front-end/InjectedScript.js:
+        (injectedScriptConstructor):
+
 2010-06-20  Robert Hogan  <robert@webkit.org>
 

trunk/WebCore/inspector/front-end/InjectedScript.js

@@ -231 +231 @@
 }
 
+// Automatically generate the list of CSS properties, and convert
+// them to their JavaScript accessible form.
+InjectedScript._hiddenStyleProperties = (function() {
+    var properties = [];
+
+    var keywords = window.getComputedStyle(document.documentElement);
+    for (var i = 0, len = keywords.length; i < len; ++i) {
+        // Strip leading hyphen from "-vendor" properties.
+        var property = keywords[i];
+        if (property.charAt(0) === "-")
+            property = property.substring(1);
+
+        // Turn hypens points into camel case points.
+        properties[i] = property.replace(/\-./g, function(match) {
+            return match.charAt(1).toUpperCase();
+        });
+    }
+
+    return properties;
+})();
+
+InjectedScript._addHiddenStyleProperties = function(resultSet)
+{
+    var hiddenStyleProperties = InjectedScript._hiddenStyleProperties;
+    for (var i = 0, length = hiddenStyleProperties.length; i < length; ++i)
+        resultSet[hiddenStyleProperties[i]] = true;
+}
+
 InjectedScript.getCompletions = function(expression, includeInspectorCommandLineAPI, callFrameId)
 {
@@ -254 +282 @@
             expressionResult = InjectedScript._evaluateOn(inspectedWindow.eval, inspectedWindow, expression, false);
         }
-        if (typeof expressionResult == "object")
+
+        if (typeof expressionResult === "object") {
             InjectedScript._populatePropertyNames(expressionResult, props);
+            if (expressionResult.constructor === inspectedWindow.document.documentElement.style.constructor)
+                InjectedScript._addHiddenStyleProperties(props);
+        }
 
         if (includeInspectorCommandLineAPI) {