Changeset 61554 in webkit

Timestamp:

Jun 21, 2010 10:43:39 AM (14 years ago)

Author:

Adam Roben

Message:

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <​http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

• platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/win/NetworkStateNotifierWin.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-21  Adam Roben  <aroben@apple.com>
+
+        Call NotifyAddrChange again each time we are notified of a change
+
+        NotifyAddrChange only notifies you of a single change. If you want to
+        listen for subsequent changes, you have to call it again.
+
+        Fixes <http://webkit.org/b/33004> NetworkStateNotifier ignores all
+        state changes after the first.
+
+        No test possible, as we don't have a way to modify the system's
+        network adapters when running tests.
+
+        Reviewed by Anders Carlsson.
+
+        * platform/network/win/NetworkStateNotifierWin.cpp:
+        (WebCore::NetworkStateNotifier::addrChangeCallback): Call
+        registerForAddressChange as soon as we're notified of an address
+        change, so we'll also get notified of the *next* address change. I
+        added the call here instead of in addressChanged (which is called
+        later on the main thread) to minimize the time between the callback
+        and registering again (so that we won't miss changes that happen in
+        rapid succession).
+
 2010-06-21  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/platform/network/win/NetworkStateNotifierWin.cpp

@@ -89 +89 @@
 void CALLBACK NetworkStateNotifier::addrChangeCallback(void* context, BOOLEAN timedOut)
 {
+    // NotifyAddrChange only notifies us of a single address change. Now that we've been notified,
+    // we need to call it again so we'll get notified the *next* time.
+    static_cast<NetworkStateNotifier*>(context)->registerForAddressChange();
+
     callOnMainThread(callAddressChanged, context);
 }