Changeset 61605 in webkit


Ignore:
Timestamp:
Jun 22, 2010 12:13:09 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-06-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Tests for:
Space should be allowed between -- and > in comment end
​https://bugs.webkit.org/show_bug.cgi?id=21945

  • fast/css/word-space-extra.html: Tweaked the comment as -- > is now a valid comment end.
  • fast/parser/broken-comment-1-expected.txt: Added.
  • fast/parser/broken-comment-1.html: Added.
  • fast/parser/broken-comment-2-expected.txt: Added.
  • fast/parser/broken-comment-2.html: Added.
  • fast/parser/broken-comment-3-expected.txt: Added.
  • fast/parser/broken-comment-3.html: Added.
  • fast/parser/broken-comment-4-expected.txt: Added.
  • fast/parser/broken-comment-4.html: Added.
  • fast/parser/broken-comment-5-expected.txt: Added.
  • fast/parser/broken-comment-5.html: Added.
  • fast/parser/broken-comment-6-expected.txt: Added.
  • fast/parser/broken-comment-6.html: Added. Those test checks that broken comments in body are correctly parsed.
  • fast/parser/broken-comment-in-head-1-expected.txt: Added.
  • fast/parser/broken-comment-in-head-1.html: Added.
  • fast/parser/broken-comment-in-head-2-expected.txt: Added.
  • fast/parser/broken-comment-in-head-2.html: Added.
  • fast/parser/broken-comment-in-head-3-expected.txt: Added.
  • fast/parser/broken-comment-in-head-3.html: Added.
  • fast/parser/broken-comment-in-head-4-expected.txt: Added.
  • fast/parser/broken-comment-in-head-4.html: Added.
  • fast/parser/broken-comment-in-head-5-expected.txt: Added.
  • fast/parser/broken-comment-in-head-5.html: Added. Those test checks that broken comments in head are correctly parsed.
  • fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment in a title as we match FF here and would not recover from it.
  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html: Added more tests for comment parsing. Made sure that we close empty comments <!--> and <!---> as is specified in HTML5.
Location:
trunk/LayoutTests
Files:
22 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r61604 r61605  
     12010-06-21  Julien Chaffraix  <jchaffraix@webkit.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        Tests for:
     6        Space should be allowed between -- and > in comment end
     7        https://bugs.webkit.org/show_bug.cgi?id=21945
     8
     9        * fast/css/word-space-extra.html: Tweaked the comment as -- > is now
     10        a valid comment end.
     11
     12        * fast/parser/broken-comment-1-expected.txt: Added.
     13        * fast/parser/broken-comment-1.html: Added.
     14        * fast/parser/broken-comment-2-expected.txt: Added.
     15        * fast/parser/broken-comment-2.html: Added.
     16        * fast/parser/broken-comment-3-expected.txt: Added.
     17        * fast/parser/broken-comment-3.html: Added.
     18        * fast/parser/broken-comment-4-expected.txt: Added.
     19        * fast/parser/broken-comment-4.html: Added.
     20        * fast/parser/broken-comment-5-expected.txt: Added.
     21        * fast/parser/broken-comment-5.html: Added.
     22        * fast/parser/broken-comment-6-expected.txt: Added.
     23        * fast/parser/broken-comment-6.html: Added.
     24        Those test checks that broken comments in body are correctly parsed.
     25        * fast/parser/broken-comment-in-head-1-expected.txt: Added.
     26        * fast/parser/broken-comment-in-head-1.html: Added.
     27        * fast/parser/broken-comment-in-head-2-expected.txt: Added.
     28        * fast/parser/broken-comment-in-head-2.html: Added.
     29        * fast/parser/broken-comment-in-head-3-expected.txt: Added.
     30        * fast/parser/broken-comment-in-head-3.html: Added.
     31        * fast/parser/broken-comment-in-head-4-expected.txt: Added.
     32        * fast/parser/broken-comment-in-head-4.html: Added.
     33        * fast/parser/broken-comment-in-head-5-expected.txt: Added.
     34        * fast/parser/broken-comment-in-head-5.html: Added.
     35        Those test checks that broken comments in head are correctly parsed.
     36
     37        * fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment
     38        in a title as we match FF here and would not recover from it.
     39
     40        * fast/parser/comments-expected.txt:
     41        * fast/parser/comments.html:
     42        Added more tests for comment parsing. Made sure that we close empty comments
     43        <!--> and <!---> as is specified in HTML5.
     44
    1452010-06-21  Adam Barth  <abarth@webkit.org>
    246

  • trunk/LayoutTests/fast/parser/broken-comments-vs-parsing-mode.html

    r60786 r61605  
    11<html>
     2<head>
     3<title>
    24<!-- A broken comment ->
     5</title>
     6</head>
    37<body>
    48<p><a href="https://bugs.webkit.org/show_bug.cgi?id=8626">bug 8626</a>:

  • trunk/LayoutTests/fast/parser/comments-expected.txt

    r61234 r61605  
    1 Output of this test should match WinIE (no strict SGML comment parsing).
     1Output of this test should match HTML5 (no strict SGML comment parsing).
    22
    3 Basic comments (1 PASSED):
    4 PASSED FAILED-->
     3Basic comments (2 PASSED):
     4PASSED PASSED
     5Comment series (3 PASSED):
     6PASSED PASSED PASSED
    57
    6 Comment series (1 PASSED):
    7 PASSED FAILED-->
     8Dash runs (5 PASSED):
     9PASSED PASSED PASSED PASSED PASSED
    810
    9 Dash runs (3 PASSED):
    10 PASSED FAILED PASSED PASSED
     11Empty comments (5 PASSED):
     12PASSED PASSED PASSED PASSED PASSED
    1113
    12 Empty comments (2 PASSED):
    13 PASSED FAILED--> PASSED
     14Multiple lines (4 PASSED):
     15PASSED PASSED PASSED PASSED
    1416
    15 Multiple lines (1 PASSED):
    16 PASSED FAILED-->
     17Compatibility (7 PASSED):
     18PASSED PASSED PASSED PASSED PASSED PASSED PASSED
    1719
    18 Compatibility (2 PASSED):
    19 PASSED FAILED--> PASSED FAILED-->
    20 
    21 Tab after comment close:
    22 FAILED: should be part of the comment -->
     20White space after comment close (4 PASSED):
     21PASSED PASSED PASSED PASSED
    2322
    2423Text after comment close:
    25 Extra comment after markup declaration close:
     24Extra comment after markup declaration close (2 PASSED):
    2625FAILED: extra comment end and markup declaration close -->
    27 FAILED: extra comment end w/space and markup declaration close -->
     26PASSED PASSED
    2827
    2928Nested comment (1 PASSED):

  • trunk/LayoutTests/fast/parser/comments.html

    r60786 r61605  
    22<html>
    33<body>
    4 <p>Output of this test should match WinIE (no strict SGML comment parsing).</p>
     4<p>Output of this test should match HTML5 (no strict SGML comment parsing).</p>
    55
    66<script>
    … …  
    88    layoutTestController.dumpAsText();
    99</script>
    10 <p>Basic comments (1 PASSED):<br>
     10<p>Basic comments (2 PASSED):<br>
    1111<!-- basic comment -->PASSED
    12 <!-- basic comment with spaces after comment end --    >FAILED--></p>
    13 <p>Comment series (1 PASSED):<br>
     12<!-- basic comment with spaces after comment end --    >PASSED
     13<!-- basic comment with spaces after comment end - -    >FAILED--></p>
     14<p>Comment series (3 PASSED):<br>
    1415<!-- comment -- -- series-->PASSED
    15 <!-- comment -- -- series with spaces after comment end-- >FAILED--></p>
    16 <p>Dash runs (3 PASSED):<br>
     16<!-- comment -- -- series with space after comment end-- >PASSED
     17<!-- comment -- -- series with spaces after comment end--  >PASSED</p>
     18<!-- comment -- -- series with spaces after comment end- -  >FAILED--></p>
     19<p>Dash runs (5 PASSED):<br>
    1720<!------ Hello -->PASSED
    18 <!------ Hello -- >FAILED
     21<!------ Hello -- >PASSED
     22<!------ Hello --  >PASSED
     23<!------ Hello - -  >FAILED
    1924<!-- --- Hello -->PASSED
    2025<!-- Hello --->PASSED</p>
    21 <p>Empty comments (2 PASSED):<br>
     26<p>Empty comments (5 PASSED):<br>
    2227<!---->PASSED
    23 <!---- >FAILED-->
    24 <!>PASSED</p>
    25 <p>Multiple lines (1 PASSED):<br>
     28<!---- >PASSED
     29<!>PASSED
     30<!-->PASSED
     31<!--->PASSED</p>
     32<p>Multiple lines (4 PASSED):<br>
    2633<!-- here's a comment, a little longer,
    2734    which occupies more than one line -->PASSED
    2835<!-- here's a comment, a little longer,
    29     which occupies more than one line -- >FAILED-->
     36    which occupies more than one line -- >PASSED
     37<!-- here's a comment, a little longer,
     38    which occupies more than one line --         >PASSED
     39<!-- here's a comment, a little longer,
     40    which occupies more than one line --         
     41    >PASSED
     42<!-- here's a comment, a little longer,
     43    which occupies more than one line - -        >FAILED-->
    3044</p>
    3145
    32 <p>Compatibility (2 PASSED):<br>
     46<p>Compatibility (7 PASSED):<br>
    3347<!-- Compatibility: comment series with --extraneous-- text -- between -- the comments -->PASSED
    34 <!-- Compatibility: comment series with --extraneous-- text -- between -- the comments -- >FAILED-->
     48<!-- Compatibility: comment series with --extraneous-- text -- between -- the comments -- >PASSED
     49<!-- Compatibility: comment series with --extraneous-- text -- between -- the comments --  >PASSED
     50<!-- Compatibility: comment series with --extraneous-- text -- between -- the comments - -  >FAILED-->
    3551<!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539>-->PASSED
    36 <!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539> -- >FAILED-->
     52<!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539>-- >PASSED
     53<!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539> --  >PASSED
     54<!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539> --  >PASSED
     55<!-- Compatibility: <!--extra comment start like www.the-leaky-cauldron.com has <rdar://problem/4226539> - -  >FAILED-->
    3756</p>
    3857
    39 <p>Tab after comment close:<br>
    40 <!-- tab after comment close--  >FAILED: should be part of the comment --></p>
     58<p>White space after comment close (4 PASSED):<br>
     59<!-- tab after comment close--  >PASSED
     60<!-- LF after comment close--
     61>PASSED
     62<!-- CR after comment close--
     63>PASSED
     64<!-- tab after comment close--  >PASSED</p>
     65
     66
    4167<p>Text after comment close:<br>
    4268<!-- text after comment close--ouch>FAILED: should be part of the comment --></p>
    4369
    4470
    45 <p>Extra comment after markup declaration close:<br>
     71<p>Extra comment after markup declaration close (2 PASSED):<br>
    4672<!-- Comment --> FAILED: extra comment end and markup declaration close --><br>
    47 <!-- Comment with a whitespace in markup declaration close -- > FAILED: extra comment end w/space and markup declaration close --></p>
     73<!-- Comment with a whitespace in markup declaration close -- >PASSED
     74<!-- Comment with a whitespace in markup declaration close --    >PASSED</p>
    4875
    4976<p>Nested comment (1 PASSED):<br>

  • trunk/LayoutTests/platform/mac/fast/parser/broken-comments-vs-parsing-mode-expected.txt

    r61234 r61605  
    33layer at (0,0) size 800x600
    44  RenderBlock {HTML} at (0,0) size 800x600
    5     RenderBody {BODY} at (8,8) size 784x584
     5    RenderBody {BODY} at (8,8) size 784x576
     6      RenderBlock {P} at (0,0) size 784x18
     7        RenderInline {A} at (0,0) size 60x18 [color=#0000EE]
     8          RenderText {#text} at (0,0) size 60x18
     9            text run at (0,0) width 60: "bug 8626"
     10        RenderText {#text} at (60,0) size 363x18
     11          text run at (60,0) width 8: ": "
     12          text run at (68,0) width 355: "Strict mode erroneously triggered by a broken comment."
     13      RenderBlock {P} at (0,34) size 784x18 [color=#00FF00]
     14        RenderText {#text} at (0,0) size 642x18
     15          text run at (0,0) width 642: "This text should be green, not black (CSS color values not beginning with '#' are OK in quirks mode)."
Note: See TracChangeset for help on using the changeset viewer.