Changeset 61617 in webkit

Timestamp:

Jun 22, 2010 7:58:46 AM (14 years ago)

Author:

yurys@chromium.org

Message:

2010-06-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/elements-panel-limited-children.html test fails
​https://bugs.webkit.org/show_bug.cgi?id=40924

• http/tests/inspector/inspector-test.js: (onload): (frontend_setupTestEnvironment): always start inspector test with Elements panel as current one.
• inspector/elements-panel-limited-children.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/inspector/inspector-test.js (modified) (2 diffs)
• inspector/elements-panel-limited-children.html (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-22  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: inspector/elements-panel-limited-children.html test fails
+        https://bugs.webkit.org/show_bug.cgi?id=40924
+
+        * http/tests/inspector/inspector-test.js:
+        (onload):
+        (frontend_setupTestEnvironment): always start inspector test with Elements panel as current one.
+        * inspector/elements-panel-limited-children.html:
+
 2010-06-22  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/http/tests/inspector/inspector-test.js

@@ -19 +19 @@
             toInject.push(window[name].toString());
     }
+    toInject.push("frontend_setupTestEnvironment();");
     evaluateInWebInspector(toInject.join("\n"), doit);
 }
@@ -100 +101 @@
         frontend_dumpTreeItem(children[i], result, prefix + "    ");
 }
+
+function frontend_setupTestEnvironment()
+{
+   WebInspector.showElementsPanel();
+}

trunk/LayoutTests/inspector/elements-panel-limited-children.html

@@ -56 +56 @@
             notifyDone();
         }
-        evaluateInWebInspector("frontend_expandNode", nodeExpandedCallback);
+        evaluateInWebInspector("frontend_revealAndExpandDataNodeInElementsPanel", nodeExpandedCallback);
     }
 
     evaluateInWebInspector("frontend_loadDOM", domLoadedCallback);
 }
-
 
 // Frontend functions.
@@ -107 +106 @@
 }
 
-function frontend_expandNode(testController)
+function frontend_revealAndExpandDataNodeInElementsPanel(testController)
 {
     var dataDivTreeElement = frontend_getDataTreeElement();
@@ -141 +140 @@
     if (!node)
         return null;
-    return WebInspector.panels.elements.treeOutline.createTreeElementFor(node);
+    return WebInspector.panels.elements.treeOutline.findTreeElement(node);
 }
 
@@ -151 +150 @@
     for (var nodeId in innerMapping) {
         var node = innerMapping[nodeId];
-        if (node.nodeName === "DIV" || node.getAttribute("id") === "data")
+        if (node.nodeName === "DIV" && node.getAttribute("id") === "data")
             return node;
     }