Changeset 61660 in webkit
- Timestamp:
- Jun 22, 2010 11:30:15 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r61644 r61660 1 2010-06-22 Sam Magnuson <smagnuson@netflix.com> 2 3 Reviewed by Shinichiro Hamaji. 4 5 Follow proper convention for variable declaration spacing. 6 https://bugs.webkit.org/show_bug.cgi?id=40724 7 8 Modified test so that 'int a;' is not allowed. 9 10 * Scripts/webkitpy/style/checkers/cpp.py: 11 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 12 1 13 2010-06-22 Eric Seidel <eric@webkit.org> 2 14 -
trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp.py
r60293 r61660 1369 1369 error(line_number, 'whitespace/comma', 3, 1370 1370 'Missing space after ,') 1371 1372 matched = search(r'^\s*(?P<token1>[a-zA-Z0-9_\*&]+)\s\s+(?P<token2>[a-zA-Z0-9_\*&]+)', line) 1373 if matched: 1374 error(line_number, 'whitespace/declaration', 3, 1375 'Extra space between %s and %s' % (matched.group('token1'), matched.group('token2'))) 1371 1376 1372 1377 if file_extension == 'cpp': -
trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py
r60293 r61660 1543 1543 self.assert_lint('f(a, /* name */b);', '') 1544 1544 1545 def test_declaration(self): 1546 self.assert_lint('int a;', '') 1547 self.assert_lint('int a;', 'Extra space between int and a [whitespace/declaration] [3]') 1548 self.assert_lint('int* a;', 'Extra space between int* and a [whitespace/declaration] [3]') 1549 self.assert_lint('else if { }', '') 1550 self.assert_lint('else if { }', 'Extra space between else and if [whitespace/declaration] [3]') 1551 1545 1552 def test_pointer_reference_marker_location(self): 1546 1553 self.assert_lint('int* b;', '', 'foo.cpp')
Note: See TracChangeset
for help on using the changeset viewer.