Changeset 61859 in webkit


Ignore:
Timestamp:
Jun 25, 2010 6:32:18 AM (14 years ago)
Author:
yurys@chromium.org
Message:

2010-06-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Can't see source when hitting debugger statement in evaled source
https://bugs.webkit.org/show_bug.cgi?id=41058

Test: inspector/debugger-pause-in-eval-script.html

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::sourceParsed): use lexical global object to figure out where the script is compiled. Otherwise scripts typed in Web Inspector console will be treated as ones evaluated in the context of Web Inspector and won't appear in the scripts list.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): cache script sources for eval's too.

2010-06-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Can't see source when hitting debugger statement in evaled source
https://bugs.webkit.org/show_bug.cgi?id=41058

Test that debugger will stop at a debugger statement in code evaluated
in Web Inspector console.

  • inspector/debugger-pause-in-eval-script-expected.txt: Added.
  • inspector/debugger-pause-in-eval-script.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r61855 r61859  
     12010-06-25  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Can't see source when hitting debugger statement in evaled source
     6        https://bugs.webkit.org/show_bug.cgi?id=41058
     7
     8        Test that debugger will stop at a debugger statement in code evaluated
     9        in Web Inspector console.
     10
     11        * inspector/debugger-pause-in-eval-script-expected.txt: Added.
     12        * inspector/debugger-pause-in-eval-script.html: Added.
     13
    1142010-06-25  Mikhail Naganov  <mnaganov@chromium.org>
    215
  • trunk/LayoutTests/platform/qt/Skipped

    r61757 r61859  
    54555455# https://bugs.webkit.org/show_bug.cgi?id=41147
    54565456inspector/debugger-pause-on-debugger-statement.html
     5457inspector/debugger-pause-in-eval-script.html
  • trunk/WebCore/ChangeLog

    r61854 r61859  
     12010-06-25  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Can't see source when hitting debugger statement in evaled source
     6        https://bugs.webkit.org/show_bug.cgi?id=41058
     7
     8        Test: inspector/debugger-pause-in-eval-script.html
     9
     10        * bindings/js/ScriptDebugServer.cpp:
     11        (WebCore::ScriptDebugServer::sourceParsed): use lexical global object to figure out
     12        where the script is compiled. Otherwise scripts typed in Web Inspector console will
     13        be treated as ones evaluated in the context of Web Inspector and won't appear in the
     14        scripts list.
     15        * inspector/InspectorController.cpp:
     16        (WebCore::InspectorController::didParseSource): cache script sources for eval's too.
     17
    1182010-06-25  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
    219
  • trunk/WebCore/bindings/js/ScriptDebugServer.cpp

    r61749 r61859  
    324324        return;
    325325
    326     Page* page = toPage(exec->dynamicGlobalObject());
     326    Page* page = toPage(exec->lexicalGlobalObject());
    327327    if (!page)
    328328        return;
  • trunk/WebCore/inspector/InspectorController.cpp

    r61772 r61859  
    17731773    m_frontend->parsedScriptSource(sourceID, url, "", firstLine, worldType);
    17741774
     1775    m_scriptIDToContent.set(sourceID, data);
     1776
    17751777    if (url.isEmpty())
    17761778        return;
     
    17861788        }
    17871789    }
    1788 
    17891790    m_sourceIDToURL.set(sourceID, url);
    1790     m_scriptIDToContent.set(sourceID, data);
    17911791}
    17921792
Note: See TracChangeset for help on using the changeset viewer.