Changeset 61988 in webkit

Timestamp:

Jun 28, 2010 2:29:57 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-06-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the html5lib runner.html not assert
​https://bugs.webkit.org/show_bug.cgi?id=41273

This patch gets us closer to being able to run the parser tests. We
still don't get parsing correct, but at least we don't assert. :)

• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::insertCommentOnDocument):
• html/HTMLTreeBuilder.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLTreeBuilder.cpp (modified) (3 diffs)
• html/HTMLTreeBuilder.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-28  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Make the html5lib runner.html not assert
+        https://bugs.webkit.org/show_bug.cgi?id=41273
+
+        This patch gets us closer to being able to run the parser tests.  We
+        still don't get parsing correct, but at least we don't assert.  :)
+
+        * html/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processStartTag):
+        (WebCore::HTMLTreeBuilder::processComment):
+        (WebCore::HTMLTreeBuilder::insertCommentOnDocument):
+        * html/HTMLTreeBuilder.h:
+
 2010-06-28  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/html/HTMLTreeBuilder.cpp

@@ -331 +331 @@
             m_framesetOk = false;
             insertElement(token);
+            m_insertionMode = InBodyMode;
             return;
         }
@@ -651 +652 @@
 void HTMLTreeBuilder::processComment(AtomicHTMLToken& token)
 {
+    if (m_insertionMode == InitialMode || m_insertionMode == BeforeHTMLMode) {
+        insertCommentOnDocument(token);
+        return;
+    }
     insertComment(token);
 }
@@ -794 +799 @@
     ASSERT(token.type() == HTMLToken::Comment);
     currentElement()->addChild(Comment::create(m_document, token.comment()));
+}
+
+void HTMLTreeBuilder::insertCommentOnDocument(AtomicHTMLToken& token)
+{
+    ASSERT(token.type() == HTMLToken::Comment);
+    m_document->addChild(Comment::create(m_document, token.comment()));
 }
 

trunk/WebCore/html/HTMLTreeBuilder.h

@@ -178 +178 @@
     void insertDoctype(AtomicHTMLToken&);
     void insertComment(AtomicHTMLToken&);
+    void insertCommentOnDocument(AtomicHTMLToken&);
     void insertElement(AtomicHTMLToken&);
     void insertSelfClosingElement(AtomicHTMLToken&);