Changeset 61990 in webkit

Timestamp:

Jun 28, 2010 2:56:30 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-06-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't dump contents of <script> elements in LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=41277

Apparently we need to tell each element when we start and stop parsing
its children. If we don't do this, we see the contents of every script
and style element in dumpAsText LayoutTests. (This patch is *well*
covered by LayoutTests.)

• html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLTreeBuilder.h (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-28  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Don't dump contents of <script> elements in LayoutTests
+        https://bugs.webkit.org/show_bug.cgi?id=41277
+
+        Apparently we need to tell each element when we start and stop parsing
+        its children.  If we don't do this, we see the contents of every script
+        and style element in dumpAsText LayoutTests.  (This patch is *well*
+        covered by LayoutTests.)
+
+        * html/HTMLTreeBuilder.h:
+        (WebCore::HTMLTreeBuilder::ElementStack::pop):
+        (WebCore::HTMLTreeBuilder::ElementStack::push):
+
 2010-06-28  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/html/HTMLTreeBuilder.h

@@ -27 +27 @@
 #define HTMLTreeBuilder_h
 
+#include "Element.h"
 #include "FragmentScriptingPermission.h"
 #include "HTMLTokenizer.h"
@@ -41 +42 @@
 class Document;
 class DocumentFragment;
-class Element;
 class Frame;
 class HTMLToken;
@@ -123 +123 @@
         void pop()
         {
+            top()->finishParsingChildren();
             m_top = m_top->releaseNext();
         }
@@ -129 +130 @@
         {
             m_top.set(new ElementRecord(element, m_top.release()));
+            top()->beginParsingChildren();
         }