Changeset 62136 in webkit

Timestamp:

Jun 29, 2010 11:08:32 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-06-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Darin Fisher.

A crash caused by the patch of bug 40608.
​https://bugs.webkit.org/show_bug.cgi?id=41334

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-06-29  Zhe Su  <suzhe@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        A crash caused by the patch of bug 40608.
+        https://bugs.webkit.org/show_bug.cgi?id=41334
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::caretOrSelectionBounds):
+
 2010-06-29  Victor Wang  <victorw@chromium.org>
 

trunk/WebKit/chromium/src/WebViewImpl.cpp

@@ -1287 +1287 @@
         return rect;
 
+    const Node* node = controller->start().node();
+    if (!node || !node->renderer())
+        return rect;
+
     if (controller->isCaret())
         rect = view->contentsToWindow(controller->absoluteCaretBounds());