Changeset 62143 in webkit

Timestamp:

Jun 29, 2010 1:01:23 PM (14 years ago)

Author:

andersca@apple.com

Message:

2010-06-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a private Message class template
​https://bugs.webkit.org/show_bug.cgi?id=41370

• Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::Message): (CoreIPC::Connection::Message::arguments):

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/Connection.h (modified) (3 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-06-29  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Add a private Message class template
+        https://bugs.webkit.org/show_bug.cgi?id=41370
+
+        * Platform/CoreIPC/Connection.h:
+        (CoreIPC::Connection::Message::Message):
+        (CoreIPC::Connection::Message::arguments):
+
 2010-06-28  John Gregg  <johnnyg@google.com>
 

trunk/WebKit2/Platform/CoreIPC/Connection.h

@@ -109 +109 @@
     RunLoop* m_clientRunLoop;
 
-    // Incoming messages.
-    class IncomingMessage {
+    template<typename T> class Message {
     public:
-        IncomingMessage(MessageID messageID, std::auto_ptr<ArgumentDecoder> arguments)
+        Message(MessageID messageID, std::auto_ptr<T> arguments)
             : m_messageID(messageID)
             , m_arguments(arguments.release())
         {
         }
-
+        
         MessageID messageID() const { return m_messageID; }
-        ArgumentDecoder* arguments() const { return m_arguments; }
+        T* arguments() const { return m_arguments; }
         
         void destroy() 
@@ -128 +127 @@
     private:
         MessageID m_messageID;
-        ArgumentDecoder* m_arguments;
+        T* m_arguments;
     };
+
+    // Incoming messages.
+    typedef Message<ArgumentDecoder> IncomingMessage;
 
     Mutex m_incomingMessagesLock;
@@ -135 +137 @@
 
     // Outgoing messages.
-    class OutgoingMessage {
-    public:
-        OutgoingMessage(MessageID messageID, std::auto_ptr<ArgumentEncoder> arguments)
-            : m_messageID(messageID)
-            , m_arguments(arguments.release())
-        {
-        }
-        
-        MessageID messageID() const { return m_messageID; }
-        ArgumentEncoder* arguments() const { return m_arguments; }
-        
-        void destroy()
-        {
-            delete m_arguments;
-        }
-        
-    private:
-        MessageID m_messageID;
-        ArgumentEncoder* m_arguments;
-    };
-    
+    typedef Message<ArgumentEncoder> OutgoingMessage;
+
     Mutex m_outgoingMessagesLock;
     Vector<OutgoingMessage> m_outgoingMessages;