Changeset 62434 in webkit


Ignore:
Timestamp:
Jul 2, 2010 11:07:52 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

This patch is kind of goofy but apparently how the world works.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::setName):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r62433 r62434  
     12010-07-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Handle <image> in new parser
     6        https://bugs.webkit.org/show_bug.cgi?id=41555
     7
     8        Test progression.
     9
     10        * html5lib/runner-expected-html5.txt:
     11
    1122010-07-02  Oliver Hunt  <oliver@apple.com>
    213
  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62378 r62434  
    424282
    434386
    44 89
    454490
    464593
     
    10511050|             <span>
    10521051|               "X"
    1053 
    1054 Test 89 of 113 in resources/tests1.dat failed. Input:
    1055 <p><image></p>
    1056 Got:
    1057 | <html>
    1058 |   <head>
    1059 |   <body>
    1060 |     <p>
    1061 Expected:
    1062 | <html>
    1063 |   <head>
    1064 |   <body>
    1065 |     <p>
    1066 |       <img>
    10671052
    10681053Test 90 of 113 in resources/tests1.dat failed. Input:
  • trunk/WebCore/ChangeLog

    r62431 r62434  
     12010-07-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Handle <image> in new parser
     6        https://bugs.webkit.org/show_bug.cgi?id=41555
     7
     8        This patch is kind of goofy but apparently how the world works.
     9
     10        * html/HTMLToken.h:
     11        (WebCore::AtomicHTMLToken::setName):
     12        * html/HTMLTreeBuilder.cpp:
     13        (WebCore::HTMLTreeBuilder::processStartTag):
     14
    1152010-07-02  Kwang Yul Seo  <skyul@company100.net>
    216
  • trunk/WebCore/html/HTMLToken.h

    r62352 r62434  
    352352    }
    353353
     354    void setName(const AtomicString& name)
     355    {
     356        ASSERT(m_type == HTMLToken::StartTag || m_type == HTMLToken::EndTag || m_type == HTMLToken::DOCTYPE);
     357        m_name = name;
     358    }
     359
    354360    bool selfClosing() const
    355361    {
  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62376 r62434  
    485485            return;
    486486        }
     487        if (token.name() == imageTag) {
     488            parseError(token);
     489            // Apparently we're not supposed to ask.
     490            token.setName(imgTag.localName());
     491            // Note the fall through to the imgTag handling below!
     492        }
    487493        if (token.name() == areaTag || token.name() == basefontTag || token.name() == "bgsound" || token.name() == brTag || token.name() == embedTag || token.name() == imgTag || token.name() == inputTag || token.name() == keygenTag || token.name() == wbrTag) {
    488494            reconstructTheActiveFormattingElements();
     
    499505            insertSelfClosingElement(token);
    500506            m_framesetOk = false;
    501             return;
    502         }
    503         if (token.name() == imageTag) {
    504             parseError(token);
    505             notImplemented();
    506             // Apparently we're not supposed to ask.
    507507            return;
    508508        }
Note: See TracChangeset for help on using the changeset viewer.