Changeset 62436 in webkit


Ignore:
Timestamp:
Jul 2, 2010 11:32:15 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-07-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
​https://bugs.webkit.org/show_bug.cgi?id=41557

There didn't seem to be test coverage of these cases in the suite, so I
added a couple tests.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
​https://bugs.webkit.org/show_bug.cgi?id=41557

So sayeth the spec.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62435 r62436  
     12010-07-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Special handling of <rp> and <rt> tags
     6        https://bugs.webkit.org/show_bug.cgi?id=41557
     7
     8        There didn't seem to be test coverage of these cases in the suite, so I
     9        added a couple tests.
     10
     11        * html5lib/resources/webkit01.dat:
     12        * html5lib/runner-expected-html5.txt:
     13        * html5lib/runner-expected.txt:
     14        * html5lib/webkit-resumer-expected.txt:
     15
    1162010-07-02  Adam Barth  <abarth@webkit.org>
    217

  • trunk/LayoutTests/html5lib/resources/webkit01.dat

    r62375 r62436  
    310310|     <!--  Hi there  -->
    311311| <!--  Again  -->
     312
     313#data
     314<html><body><ruby><div><rp>xx</rp></div></ruby></body></html>
     315#errors
     316#document
     317| <html>
     318|   <head>
     319|   <body>
     320|     <ruby>
     321|       <div>
     322|       <rp>
     323|         "xx"
     324
     325#data
     326<html><body><ruby><div><rt>xx</rt></div></ruby></body></html>
     327#errors
     328#document
     329| <html>
     330|   <head>
     331|   <body>
     332|     <ruby>
     333|       <div>
     334|       <rt>
     335|         "xx"

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62435 r62436  
    5510551017
    55115511
    5512 Test 17 of 27 in resources/webkit01.dat failed. Input:
     5512Test 17 of 29 in resources/webkit01.dat failed. Input:
    55135513<A>test< /A>
    55145514Got:

  • trunk/LayoutTests/html5lib/runner-expected.txt

    r62378 r62436  
    4693469326
    4694469427
    4695 
    4696 Test 17 of 27 in resources/webkit01.dat failed. Input:
     469528
     469629
     4697
     4698Test 17 of 29 in resources/webkit01.dat failed. Input:
    46974699<A>test< /A>
    46984700Got:
    … …  
    47104712|       "test< /A>"
    47114713
    4712 Test 20 of 27 in resources/webkit01.dat failed. Input:
     4714Test 20 of 29 in resources/webkit01.dat failed. Input:
    47134715<body></br foo="bar"></body>
    47144716Got:
    … …  
    47244726|     <br>
    47254727
    4726 Test 22 of 27 in resources/webkit01.dat failed. Input:
     4728Test 22 of 29 in resources/webkit01.dat failed. Input:
    47274729<body></body></br foo="bar">
    47284730Got:
    … …  
    47384740|     <br>
    47394741
    4740 Test 24 of 27 in resources/webkit01.dat failed. Input:
     4742Test 24 of 29 in resources/webkit01.dat failed. Input:
    47414743<html><body></body></html><!-- Hi there -->
    47424744Got:
    … …  
    47514753| <!--  Hi there  -->
    47524754
    4753 Test 26 of 27 in resources/webkit01.dat failed. Input:
     4755Test 26 of 29 in resources/webkit01.dat failed. Input:
    47544756<html><body></body></html>x<!-- Hi there --></html><!-- Again -->
    47554757Got:
    … …  
    47684770| <!--  Again  -->
    47694771
    4770 Test 27 of 27 in resources/webkit01.dat failed. Input:
     4772Test 27 of 29 in resources/webkit01.dat failed. Input:
    47714773<html><body></body></html>x<!-- Hi there --></body></html><!-- Again -->
    47724774Got:
    … …  
    47844786|     <!--  Hi there  -->
    47854787| <!--  Again  -->
     4788
     4789Test 28 of 29 in resources/webkit01.dat failed. Input:
     4790<html><body><ruby><div><rp>xx</rp></div></ruby></body></html>
     4791Got:
     4792| <html>
     4793|   <head>
     4794|   <body>
     4795|     <ruby>
     4796|       <div>
     4797|         <rp>
     4798|           "xx"
     4799Expected:
     4800| <html>
     4801|   <head>
     4802|   <body>
     4803|     <ruby>
     4804|       <div>
     4805|       <rp>
     4806|         "xx"
     4807
     4808Test 29 of 29 in resources/webkit01.dat failed. Input:
     4809<html><body><ruby><div><rt>xx</rt></div></ruby></body></html>
     4810Got:
     4811| <html>
     4812|   <head>
     4813|   <body>
     4814|     <ruby>
     4815|       <div>
     4816|         <rt>
     4817|           "xx"
     4818Expected:
     4819| <html>
     4820|   <head>
     4821|   <body>
     4822|     <ruby>
     4823|       <div>
     4824|       <rt>
     4825|         "xx"
    47864826resources/doctype01.dat: PASS
    47874827

  • trunk/LayoutTests/html5lib/webkit-resumer-expected.txt

    r62375 r62436  
    400400970.70
    401401971.71
     402972.1
     403973.2
     404974.3
     405975.4
     406976.5
     407977.6
     408978.7
     409979.8
     410980.9
     411981.10
     412982.11
     413983.12
     414984.13
     415985.14
     416986.15
     417987.16
     418988.17
     419989.18
     420990.19
     421991.20
     422992.21
     423993.22
     424994.23
     425995.24
     426996.25
     427997.26
     428998.27
     429999.28
     4301000.29
     4311001.30
     4321002.31
     4331003.32
     4341004.33
     4351005.34
     4361006.35
     4371007.36
     4381008.37
     4391009.38
     4401010.39
     4411011.40
     4421012.41
     4431013.42
     4441014.43
     4451015.44
     4461016.45
     4471017.46
     4481018.47
     4491019.48
     4501020.49
     4511021.50
     4521022.51
     4531023.52
     4541024.53
     4551025.54
     4561026.55
     4571027.56
     4581028.57
     4591029.58
     4601030.59
     4611031.60
     4621032.1
     4631033.2
     4641034.3
     4651035.4
     4661036.5
     4671037.6
     4681038.7
     4691039.8
     4701040.9
     4711041.10
     4721042.11
     4731043.12
     4741044.13
     4751045.14
     4761046.15
     4771047.16
     4781048.17
     4791049.18
     4801050.19
     4811051.20
     4821052.21
     4831053.22
     4841054.23
     4851055.24
     4861056.25
     4871057.26
     4881058.27
     4891059.28
     4901060.29
     4911061.30
     4921062.31
     4931063.32
     4941064.33
     4951065.34
     4961066.35
     4971067.36
     4981068.37
     4991069.38
     5001070.39
     5011071.40
     5021072.41
     5031073.42
     5041074.43
     5051075.44
     5061076.45
     5071077.46
     5081078.47
     5091079.48
     5101080.49
     5111081.50
     5121082.51
     5131083.52
     5141084.53
     5151085.54
     5161086.55
     5171087.56
     5181088.57
     5191089.58
     5201090.59
     5211091.60

  • trunk/WebCore/ChangeLog

    r62435 r62436  
     12010-07-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Special handling of <rp> and <rt> tags
     6        https://bugs.webkit.org/show_bug.cgi?id=41557
     7
     8        So sayeth the spec.
     9
     10        * html/HTMLTreeBuilder.cpp:
     11        (WebCore::HTMLTreeBuilder::processStartTag):
     12
    1132010-07-02  Adam Barth  <abarth@webkit.org>
    214

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62435 r62436  
    561561        }
    562562        if (token.name() == rpTag || token.name() == rtTag) {
    563             notImplemented();
     563            if (m_openElements.inScope(rubyTag.localName())) {
     564                generateImpliedEndTags();
     565                if (!currentElement()->hasTagName(rubyTag)) {
     566                    parseError(token);
     567                    m_openElements.popUntil(rubyTag.localName());
     568                }
     569            }
    564570            insertElement(token);
    565571            return;
Note: See TracChangeset for help on using the changeset viewer.