Changeset 62484 in webkit

Timestamp:

Jul 5, 2010 5:48:28 AM (14 years ago)

Author:

Nikolas Zimmermann

Message:

2010-07-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze / Darin Adler.

Node.cloneNode does not work on SVG nodes
​https://bugs.webkit.org/show_bug.cgi?id=41421

Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.

Test: svg/custom/clone-element-with-animated-svg-properties.html

• dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.checksum (added)
• LayoutTests/platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.png (added)
• LayoutTests/platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.txt (added)
• LayoutTests/svg/custom/clone-element-with-animated-svg-properties.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dirk Schulze / Darin Adler.
+
+        Node.cloneNode does not work on SVG nodes
+        https://bugs.webkit.org/show_bug.cgi?id=41421
+
+        * platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
+        * platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
+        * platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
+        * svg/custom/clone-element-with-animated-svg-properties.html: Added.
+
 2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dirk Schulze / Darin Adler.
+
+        Node.cloneNode does not work on SVG nodes
+        https://bugs.webkit.org/show_bug.cgi?id=41421
+
+        Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
+        When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
+        the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
+        attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.
+
+        Test: svg/custom/clone-element-with-animated-svg-properties.html
+
+        * dom/Element.cpp:
+        (WebCore::Element::cloneElementWithoutChildren):
+
 2010-07-05  Antti Koivisto  <koivisto@iki.fi>
 

trunk/WebCore/dom/Element.cpp

@@ -155 +155 @@
     ASSERT(isHTMLElement() == clone->isHTMLElement());
 
-    // Clone attributes.
-    if (namedAttrMap)
-        clone->attributes()->setAttributes(*attributes(true)); // Call attributes(true) to force attribute synchronization to occur (for svg and style) before cloning happens.
-    
+    // Call attributes(true) to force attribute synchronization to occur for SVG and style attributes.
+    if (NamedNodeMap* attributeMap = attributes(true))
+        clone->attributes()->setAttributes(*attributeMap);
+
     clone->copyNonAttributeProperties(this);