Changeset 62500 in webkit


Ignore:
Timestamp:
Jul 5, 2010 1:03:45 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=41590

Test the new <col> support. Turns out the old treebuilder doesn't
handle <table><col> correctly.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62499 r62500  
     12010-07-05  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Add basic <col> support to the treebuilder
     6        https://bugs.webkit.org/show_bug.cgi?id=41590
     7
     8        Test the new <col> support. Turns out the old treebuilder doesn't
     9        handle <table><col> correctly.
     10
     11        * html5lib/resources/tables01.dat:
     12        * html5lib/runner-expected-html5.txt:
     13        * html5lib/runner-expected.txt:
     14
    1152010-07-05  Eric Seidel  <eric@webkit.org>
    216

  • trunk/LayoutTests/html5lib/resources/tables01.dat

    r62499 r62500  
    2222|         <tr>
    2323|           <td>
     24
     25#data
     26<table><col foo='bar'>
     27#errors
     28#document
     29| <html>
     30|   <head>
     31|   <body>
     32|     <table>
     33|       <colgroup>
     34|         <col>
     35|           foo="bar"
     36
     37#data
     38<table><colgroup></html>foo
     39#errors
     40#document
     41| <html>
     42|   <head>
     43|   <body>
     44|     "foo"
     45|     <table>
     46|       <colgroup>

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62499 r62500  
    13561356|     <table>
    13571357|       <colgroup>
     1358|         <col>
     1359|         <col>
     1360|         <col>
     1361|         <col>
     1362|         <col>
     1363|         <col>
    13581364Expected:
    13591365| <html>
    … …  
    13811387|   <body>
    13821388|     <table>
    1383 |       <tbody>
    1384 |         <tr>
    1385 |           <td>
     1389|       <colgroup>
     1390|         <col>
     1391|         <col>
     1392|         <col>
     1393|         <col>
     1394|         <col>
    13861395Expected:
    13871396| <html>
    … …  
    56295638resources/inbody01.dat: PASS
    56305639
    5631 resources/tables01.dat: PASS
     5640resources/tables01.dat:
     56414
     5642
     5643Test 4 of 4 in resources/tables01.dat failed. Input:
     5644<table><colgroup></html>foo
     5645Got:
     5646| <html>
     5647|   <head>
     5648|   <body>
     5649|     <table>
     5650|       <colgroup>
     5651Expected:
     5652| <html>
     5653|   <head>
     5654|   <body>
     5655|     "foo"
     5656|     <table>
     5657|       <colgroup>
    56325658#EOF

  • trunk/LayoutTests/html5lib/runner-expected.txt

    r62499 r62500  
    49384938resources/inbody01.dat: PASS
    49394939
    4940 resources/tables01.dat: PASS
     4940resources/tables01.dat:
     49413
     4942
     4943Test 3 of 4 in resources/tables01.dat failed. Input:
     4944<table><col foo='bar'>
     4945Got:
     4946| <html>
     4947|   <head>
     4948|   <body>
     4949|     <table>
     4950|       <col>
     4951|         foo="bar"
     4952Expected:
     4953| <html>
     4954|   <head>
     4955|   <body>
     4956|     <table>
     4957|       <colgroup>
     4958|         <col>
     4959|           foo="bar"

  • trunk/WebCore/ChangeLog

    r62499 r62500  
     12010-07-05  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Add basic <col> support to the treebuilder
     6        https://bugs.webkit.org/show_bug.cgi?id=41590
     7
     8        * html/HTMLTreeBuilder.cpp:
     9        (WebCore::HTMLTreeBuilder::processStartTag):
     10
    1112010-07-05  Eric Seidel  <eric@webkit.org>
    212

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62499 r62500  
    747747        }
    748748        if (token.name() == colTag) {
    749             notImplemented();
     749            AtomicHTMLToken fakeToken(HTMLToken::StartTag, colgroupTag.localName());
     750            processStartTag(fakeToken);
     751            ASSERT(InColumnGroupMode);
     752            processStartTag(token);
    750753            return;
    751754        }
    … …  
    783786        }
    784787        parseError(token);
     788        notImplemented();
     789        break;
     790    case InColumnGroupMode:
     791        if (token.name() == htmlTag) {
     792            insertHTMLStartTagInBody(token);
     793            return;
     794        }
     795        if (token.name() == colTag) {
     796            insertSelfClosingElement(token);
     797            return;
     798        }
    785799        notImplemented();
    786800        break;
Note: See TracChangeset for help on using the changeset viewer.