Changeset 62562 in webkit
- Timestamp:
- Jul 6, 2010 10:25:48 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
-
LayoutTests/ChangeLog (modified) (1 diff)
-
LayoutTests/html5lib/runner-expected-html5.txt (modified) (9 diffs)
-
WebCore/ChangeLog (modified) (1 diff)
-
WebCore/html/HTMLTreeBuilder.cpp (modified) (4 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r62548 r62562 1 2010-07-06 Eric Seidel <eric@webkit.org> 2 3 Reviewed by Adam Barth. 4 5 Make <a> auto-close any parent <a> tag 6 https://bugs.webkit.org/show_bug.cgi?id=41684 7 8 * html5lib/runner-expected-html5.txt: 9 - Update expectations now that we pass 9 more subtests. 10 1 11 2010-07-06 Vitaly Repeshko <vitalyr@chromium.org> 2 12 -
trunk/LayoutTests/html5lib/runner-expected-html5.txt
r62540 r62562 6 6 20 7 7 21 8 239 2510 2811 8 30 12 3113 9 32 14 10 33 … … 18 14 79 19 15 80 20 8221 16 86 22 17 90 23 18 93 24 19 94 25 9626 9827 10028 20 103 29 21 104 … … 31 23 109 32 24 110 33 11134 25 112 35 26 … … 78 69 | <i> 79 70 | "X" 80 81 Test 23 of 113 in resources/tests1.dat failed. Input:82 <a><p>X<a>Y</a>Z</p></a>83 Got:84 | <html>85 | <head>86 | <body>87 | <a>88 | <p>89 | "X"90 | <a>91 | "Y"92 | "Z"93 Expected:94 | <html>95 | <head>96 | <body>97 | <a>98 | <p>99 | <a>100 | "X"101 | <a>102 | "Y"103 | "Z"104 105 Test 25 of 113 in resources/tests1.dat failed. Input:106 <p><b><div><marquee></p></b></div>X107 Got:108 | <html>109 | <head>110 | <body>111 | <p>112 | <b>113 | <div>114 | <marquee>115 | "X"116 Expected:117 | <html>118 | <head>119 | <body>120 | <p>121 | <b>122 | <div>123 | <b>124 | <marquee>125 | <p>126 | "X"127 128 Test 28 of 113 in resources/tests1.dat failed. Input:129 <p><hr></p>130 Got:131 | <html>132 | <head>133 | <body>134 | <p>135 | <hr>136 Expected:137 | <html>138 | <head>139 | <body>140 | <p>141 | <hr>142 | <p>143 71 144 72 Test 30 of 113 in resources/tests1.dat failed. Input: … … 172 100 | <a> 173 101 | "Y" 174 175 Test 31 of 113 in resources/tests1.dat failed. Input:176 <a X>0<b>1<a Y>2177 Got:178 | <html>179 | <head>180 | <body>181 | <a>182 | x=""183 | "0"184 | <b>185 | "1"186 | <a>187 | y=""188 | "2"189 Expected:190 | <html>191 | <head>192 | <body>193 | <a>194 | x=""195 | "0"196 | <b>197 | "1"198 | <b>199 | <a>200 | y=""201 | "2"202 102 203 103 Test 32 of 113 in resources/tests1.dat failed. Input: … … 416 316 | "aoe" 417 317 418 Test 82 of 113 in resources/tests1.dat failed. Input:419 <wbr><strike><code></strike><code><strike></code>420 Got:421 | <html>422 | <head>423 | <body>424 | <wbr>425 | <strike>426 | <code>427 | <code>428 | <strike>429 Expected:430 | <html>431 | <head>432 | <body>433 | <wbr>434 | <strike>435 | <code>436 | <code>437 | <code>438 | <strike>439 440 318 Test 86 of 113 in resources/tests1.dat failed. Input: 441 319 <table><tr><tr><td><td><span><th><span>X</table> … … 472 350 | <table> 473 351 | <a> 474 | <p> 475 | <a> 476 | <a> 477 | <div> 478 | <a> 479 | <a> 480 | <a> 352 | <p> 353 | <a> 354 | <div> 355 | <a> 481 356 Expected: 482 357 | <html> … … 534 409 | <td> 535 410 | <i> 536 537 Test 96 of 113 in resources/tests1.dat failed. Input:538 <a><p><a></a></p></a>539 Got:540 | <html>541 | <head>542 | <body>543 | <a>544 | <p>545 | <a>546 Expected:547 | <html>548 | <head>549 | <body>550 | <a>551 | <p>552 | <a>553 | <a>554 555 Test 98 of 113 in resources/tests1.dat failed. Input:556 <p><b><div><marquee></p></b></div>557 Got:558 | <html>559 | <head>560 | <body>561 | <p>562 | <b>563 | <div>564 | <marquee>565 Expected:566 | <html>567 | <head>568 | <body>569 | <p>570 | <b>571 | <div>572 | <b>573 | <marquee>574 | <p>575 576 Test 100 of 113 in resources/tests1.dat failed. Input:577 <p><hr></p>578 Got:579 | <html>580 | <head>581 | <body>582 | <p>583 | <hr>584 Expected:585 | <html>586 | <head>587 | <body>588 | <p>589 | <hr>590 | <p>591 411 592 412 Test 103 of 113 in resources/tests1.dat failed. Input: … … 734 554 | <td> 735 555 | <colgroup> 736 737 Test 111 of 113 in resources/tests1.dat failed. Input:738 </strong></b></em></i></u></strike></s></blink></tt></pre></big></small></font></select></h1></h2></h3></h4></h5></h6></body></br></a></img></title></span></style></script></table></th></td></tr></frame></area></link></param></hr></input></col></base></meta></basefont></bgsound></embed></spacer></p></dd></dt></caption></colgroup></tbody></tfoot></thead></address></blockquote></center></dir></div></dl></fieldset></listing></menu></ol></ul></li></nobr></wbr></form></button></marquee></object></html></frameset></head></iframe></image></isindex></noembed></noframes></noscript></optgroup></option></plaintext></textarea>739 Got:740 | <html>741 | <head>742 | <body>743 | <br>744 Expected:745 | <html>746 | <head>747 | <body>748 | <br>749 | <p>750 556 751 557 Test 112 of 113 in resources/tests1.dat failed. Input: -
trunk/WebCore/ChangeLog
r62561 r62562 1 2010-07-06 Eric Seidel <eric@webkit.org> 2 3 Reviewed by Adam Barth. 4 5 Make <a> auto-close any parent <a> tag 6 https://bugs.webkit.org/show_bug.cgi?id=41684 7 8 I first fixed <a> to auto-close surrounding <a> tags. 9 That caused about 3 more test passes and one new test failure. 10 The test failure was due to <marque> not adding a marker 11 to the active formatting elements. 12 13 So I made a one-line change to fix <marque>. However that hit an 14 ASSERT due to a bug in indexOfFirstUnopenFormattingElement. 15 Fixing indexOfFirstUnopenFormattingElement fixed another bunch of 16 Adoption Agency related tests (clearly this was the second typo 17 which was causing all the adoption agency failures). 18 19 However fixing <marque> and indexOfFirstUnopenFormattingElement, 20 added yet another failure due to missing support for </p> 21 automatically adding an implicit <p> tag. Fixing </p> finally 22 got the tests to a stable (all improving) state. 23 24 In the end, these 4 minor (and very well tested) tweaks fixed a total 25 of 9 subtests in html5lib/runner.html. 26 Another subtest progressed, but did not fully pass due to missing 27 <table> foster-parenting support. 28 29 * html/HTMLTreeBuilder.cpp: 30 (WebCore::HTMLTreeBuilder::processStartTagForInBody): 31 (WebCore::HTMLTreeBuilder::processEndTagForInBody): 32 (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): 33 1 34 2010-07-02 Philippe Normand <pnormand@igalia.com> 2 35 -
trunk/WebCore/html/HTMLTreeBuilder.cpp
r62540 r62562 607 607 } 608 608 if (token.name() == aTag) { 609 notImplemented(); 609 Element* activeATag = m_activeFormattingElements.closestElementInScopeWithName(aTag.localName()); 610 if (activeATag) { 611 parseError(token); 612 processFakeEndTag(aTag); 613 m_activeFormattingElements.remove(activeATag); 614 if (m_openElements.contains(activeATag)) 615 m_openElements.remove(activeATag); 616 } 610 617 reconstructTheActiveFormattingElements(); 611 618 insertFormattingElement(token); … … 626 633 reconstructTheActiveFormattingElements(); 627 634 insertElement(token); 628 notImplemented();635 m_activeFormattingElements.appendMarker(); 629 636 m_framesetOk = false; 630 637 return; … … 1371 1378 if (!m_openElements.inScope(token.name())) { 1372 1379 parseError(token); 1373 notImplemented(); 1380 processFakeStartTag(pTag); 1381 ASSERT(m_openElements.inScope(token.name())); 1382 processEndTag(token); 1374 1383 return; 1375 1384 } … … 2057 2066 } 2058 2067 } while (index); 2059 return false; 2068 firstUnopenElementIndex = index; 2069 return true; 2060 2070 } 2061 2071
Note: See TracChangeset
for help on using the changeset viewer.
