Changeset 62617 in webkit


Ignore:
Timestamp:
Jul 6, 2010 8:48:21 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix "in row" "Anything else" handling of end tags
​https://bugs.webkit.org/show_bug.cgi?id=41731

I also fixed </br> handling to follow the spec more closely
since it implementation was old and didn't use all our
new processFake* hotness.

This is already covered by 3 tests, however we don't
pass them yet, due to lack of table foster parenting
code (which Adam is working on as we speak).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
Location:
trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62613 r62617  
    318318|       <tbody>
    319319|         <tr>
     320|           <br>
    320321|     <p>
    321322Expected:
    … …  
    15761577|             <mi>
    15771578|               "foo"
    1578 |               <mi>
    1579 |                 "bar"
     1579|             <mi>
     1580|               "bar"
    15801581Expected:
    15811582| <!DOCTYPE html>
    … …  
    21192120|             <g>
    21202121|               "foo"
    2121 |               <g>
    2122 |                 "bar"
     2122|             <g>
     2123|               "bar"
    21232124Expected:
    21242125| <!DOCTYPE html>

  • trunk/WebCore/ChangeLog

    r62616 r62617  
     12010-07-06  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Fix "in row" "Anything else" handling of end tags
     6        https://bugs.webkit.org/show_bug.cgi?id=41731
     7
     8        I also fixed </br> handling to follow the spec more closely
     9        since it implementation was old and didn't use all our
     10        new processFake* hotness.
     11
     12        This is already covered by 3 tests, however we don't
     13        pass them yet, due to lack of table foster parenting
     14        code (which Adam is working on as we speak).
     15
     16        * html/HTMLTreeBuilder.cpp:
     17        (WebCore::HTMLTreeBuilder::processEndTagForInBody):
     18        (WebCore::HTMLTreeBuilder::processEndTag):
     19
    1202010-07-06  Mark Rowe  <mrowe@apple.com>
    221

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62613 r62617  
    15201520    if (token.name() == brTag) {
    15211521        parseError(token);
    1522         m_tree.reconstructTheActiveFormattingElements();
    1523         // Notice that we lose the attributes.
    1524         AtomicHTMLToken startBr(HTMLToken::StartTag, token.name());
    1525         m_tree.insertSelfClosingElement(startBr);
    1526         m_framesetOk = false;
     1522        processFakeStartTag(brTag);
    15271523        return;
    15281524    }
    … …  
    17151711            return;
    17161712        }
    1717         notImplemented();
     1713        processEndTagForInTable(token);
    17181714        break;
    17191715    case InCellMode:
Note: See TracChangeset for help on using the changeset viewer.