Changeset 62634 in webkit


Ignore:
Timestamp:
Jul 7, 2010 1:37:38 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make "in body" character handling reconstruct active formatting elements
​https://bugs.webkit.org/show_bug.cgi?id=41739

  • html5lib/runner-expected-html5.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make "in body" character handling reconstruct active formatting elements
​https://bugs.webkit.org/show_bug.cgi?id=41739

This fixes a bunch of tests, and due to some other bug in our
formatting code, regresses two. I'll fix that bug in a separate
patch.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62633 r62634  
     12010-07-06  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Make "in body" character handling reconstruct active formatting elements
     6        https://bugs.webkit.org/show_bug.cgi?id=41739
     7
     8        * html5lib/runner-expected-html5.txt:
     9
    1102010-07-06  Nikolas Zimmermann  <nzimmermann@rim.com>
    211

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62624 r62634  
    8832
    9950
    10 56
     1052
     1153
    111278
    121379
    … …  
    113114|     "-->  EOF"
    114115
    115 Test 56 of 113 in resources/tests1.dat failed. Input:
    116 <font><p>hello<b>cruel</font>world
    117 Got:
    118 | <html>
    119 |   <head>
    120 |   <body>
    121 |     <font>
     116Test 52 of 113 in resources/tests1.dat failed. Input:
     117<p id=a><b><p id=b></b>TEST
     118Got:
     119| <html>
     120|   <head>
     121|   <body>
    122122|     <p>
    123 |       <font>
    124 |         "hello"
     123|       id="a"
     124|       <b>
     125|     <p>
     126|       id="b"
     127|       <b>
     128|         "TEST"
     129Expected:
     130| <html>
     131|   <head>
     132|   <body>
     133|     <p>
     134|       id="a"
     135|       <b>
     136|     <p>
     137|       id="b"
     138|       "TEST"
     139
     140Test 53 of 113 in resources/tests1.dat failed. Input:
     141<b id=a><p><b id=b></p></b>TEST
     142Got:
     143| <html>
     144|   <head>
     145|   <body>
     146|     <b>
     147|       id="a"
     148|       <p>
    125149|         <b>
    126 |           "cruel"
    127 |       "world"
    128 Expected:
    129 | <html>
    130 |   <head>
    131 |   <body>
    132 |     <font>
    133 |     <p>
    134 |       <font>
    135 |         "hello"
     150|           id="b"
     151|       <b>
     152|         "TEST"
     153Expected:
     154| <html>
     155|   <head>
     156|   <body>
     157|     <b>
     158|       id="a"
     159|       <p>
    136160|         <b>
    137 |           "cruel"
    138 |       <b>
    139 |         "world"
     161|           id="b"
     162|       "TEST"
    140163
    141164Test 78 of 113 in resources/tests1.dat failed. Input:
    … …  
    32653288
    32663289resources/tests15.dat:
    3267 1
    3268 2
    326932905
    327032917
    … …  
    3274329511
    32753296
    3276 Test 1 of 14 in resources/tests15.dat failed. Input:
    3277 <!DOCTYPE html><p><b><i><u></p> <p>X
    3278 Got:
    3279 | <!DOCTYPE html>
    3280 | <html>
    3281 |   <head>
    3282 |   <body>
    3283 |     <p>
    3284 |       <b>
    3285 |         <i>
    3286 |           <u>
    3287 |     " "
    3288 |     <p>
    3289 |       "X"
    3290 Expected:
    3291 | <!DOCTYPE html>
    3292 | <html>
    3293 |   <head>
    3294 |   <body>
    3295 |     <p>
    3296 |       <b>
    3297 |         <i>
    3298 |           <u>
    3299 |     <b>
    3300 |       <i>
    3301 |         <u>
    3302 |           " "
    3303 |           <p>
    3304 |             "X"
    3305 
    3306 Test 2 of 14 in resources/tests15.dat failed. Input:
    3307 <p><b><i><u></p>
    3308 <p>X
    3309 Got:
    3310 | <html>
    3311 |   <head>
    3312 |   <body>
    3313 |     <p>
    3314 |       <b>
    3315 |         <i>
    3316 |           <u>
    3317 |     "
    3318 "
    3319 |     <p>
    3320 |       "X"
    3321 Expected:
    3322 | <html>
    3323 |   <head>
    3324 |   <body>
    3325 |     <p>
    3326 |       <b>
    3327 |         <i>
    3328 |           <u>
    3329 |     <b>
    3330 |       <i>
    3331 |         <u>
    3332 |           "
    3333 "
    3334 |           <p>
    3335 |             "X"
    3336 
    33373297Test 5 of 14 in resources/tests15.dat failed. Input:
    33383298<html></html><!-- foo -->
    … …  
    34873447resources/adoption01.dat:
    348834483
    3489 4
    349034495
    34913450
    … …  
    35093468|         "2"
    35103469|     "3"
    3511 
    3512 Test 4 of 9 in resources/adoption01.dat failed. Input:
    3513 <a>1<b>2</a>3</b>
    3514 Got:
    3515 | <html>
    3516 |   <head>
    3517 |   <body>
    3518 |     <a>
    3519 |       "1"
    3520 |       <b>
    3521 |         "2"
    3522 |     "3"
    3523 Expected:
    3524 | <html>
    3525 |   <head>
    3526 |   <body>
    3527 |     <a>
    3528 |       "1"
    3529 |       <b>
    3530 |         "2"
    3531 |     <b>
    3532 |       "3"
    35333470
    35343471Test 5 of 9 in resources/adoption01.dat failed. Input:

  • trunk/WebCore/ChangeLog

    r62633 r62634  
     12010-07-06  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Make "in body" character handling reconstruct active formatting elements
     6        https://bugs.webkit.org/show_bug.cgi?id=41739
     7
     8        This fixes a bunch of tests, and due to some other bug in our
     9        formatting code, regresses two.  I'll fix that bug in a separate
     10        patch.
     11
     12        * html/HTMLTreeBuilder.cpp:
     13        (WebCore::HTMLTreeBuilder::processCharacter):
     14
    1152010-07-06  Nikolas Zimmermann  <nzimmermann@rim.com>
    216

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62624 r62634  
    19811981    case InCellMode:
    19821982        ASSERT(insertionMode() == InBodyMode || insertionMode() == InCaptionMode || insertionMode() == InCellMode);
    1983         notImplemented();
     1983        m_tree.reconstructTheActiveFormattingElements();
    19841984        m_tree.insertTextNode(token);
    19851985        break;
Note: See TracChangeset for help on using the changeset viewer.