Changeset 62640 in webkit


Ignore:
Timestamp:
Jul 7, 2010 1:48:42 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs to handle <table><input>
​https://bugs.webkit.org/show_bug.cgi?id=41744

  • html5lib/runner-expected-html5.txt:

2010-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs to handle <table><input>
​https://bugs.webkit.org/show_bug.cgi?id=41744

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r62638 r62640  
     12010-07-06  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        HTMLTreeBuilder needs to handle <table><input>
     6        https://bugs.webkit.org/show_bug.cgi?id=41744
     7
     8        * html5lib/runner-expected-html5.txt:
     9
    1102010-07-06  Eric Seidel  <eric@webkit.org>
    211

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r62638 r62640  
    7377377
    7387388
    739 15
    74073916
    741 17
    742 18
    743 19
    74474024
    74574127
    … …  
    805801|   <body>
    806802
    807 Test 15 of 30 in resources/tests7.dat failed. Input:
    808 <!doctype html><table><input type=hidDEN></table>
    809 Got:
    810 | <!DOCTYPE html>
    811 | <html>
    812 |   <head>
    813 |   <body>
    814 |     <table>
    815 Expected:
    816 | <!DOCTYPE html>
    817 | <html>
    818 |   <head>
    819 |   <body>
    820 |     <table>
     803Test 16 of 30 in resources/tests7.dat failed. Input:
     804<!doctype html><table>X<input type=hidDEN></table>
     805Got:
     806| <!DOCTYPE html>
     807| <html>
     808|   <head>
     809|   <body>
     810|     <table>
     811|       "X"
    821812|       <input>
    822813|         type="hidDEN"
    823 
    824 Test 16 of 30 in resources/tests7.dat failed. Input:
    825 <!doctype html><table>X<input type=hidDEN></table>
    826 Got:
    827 | <!DOCTYPE html>
    828 | <html>
    829 |   <head>
    830 |   <body>
    831 |     <table>
    832 |       "X"
    833814Expected:
    834815| <!DOCTYPE html>
    … …  
    837818|   <body>
    838819|     "X"
    839 |     <table>
    840 |       <input>
    841 |         type="hidDEN"
    842 
    843 Test 17 of 30 in resources/tests7.dat failed. Input:
    844 <!doctype html><table>  <input type=hidDEN></table>
    845 Got:
    846 | <!DOCTYPE html>
    847 | <html>
    848 |   <head>
    849 |   <body>
    850 |     <table>
    851 |       "  "
    852 Expected:
    853 | <!DOCTYPE html>
    854 | <html>
    855 |   <head>
    856 |   <body>
    857 |     <table>
    858 |       "  "
    859 |       <input>
    860 |         type="hidDEN"
    861 
    862 Test 18 of 30 in resources/tests7.dat failed. Input:
    863 <!doctype html><table>  <input type='hidDEN'></table>
    864 Got:
    865 | <!DOCTYPE html>
    866 | <html>
    867 |   <head>
    868 |   <body>
    869 |     <table>
    870 |       "  "
    871 Expected:
    872 | <!DOCTYPE html>
    873 | <html>
    874 |   <head>
    875 |   <body>
    876 |     <table>
    877 |       "  "
    878 |       <input>
    879 |         type="hidDEN"
    880 
    881 Test 19 of 30 in resources/tests7.dat failed. Input:
    882 <!doctype html><table><input type=" hidden"><input type=hidDEN></table>
    883 Got:
    884 | <!DOCTYPE html>
    885 | <html>
    886 |   <head>
    887 |   <body>
    888 |     <table>
    889 Expected:
    890 | <!DOCTYPE html>
    891 | <html>
    892 |   <head>
    893 |   <body>
    894 |     <input>
    895 |       type=" hidden"
    896820|     <table>
    897821|       <input>

  • trunk/WebCore/ChangeLog

    r62638 r62640  
     12010-07-06  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        HTMLTreeBuilder needs to handle <table><input>
     6        https://bugs.webkit.org/show_bug.cgi?id=41744
     7
     8        * html/HTMLTreeBuilder.cpp:
     9        (WebCore::HTMLTreeBuilder::processStartTagForInTable):
     10
    1112010-07-06  Eric Seidel  <eric@webkit.org>
    212

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r62638 r62640  
    875875    }
    876876    if (token.name() == inputTag) {
    877         notImplemented();
    878         return;
     877        Attribute* typeAttribute = token.getAttributeItem(typeAttr);
     878        if (!typeAttribute || equalIgnoringCase(typeAttribute->value(), "hidden")) {
     879            parseError(token);
     880            m_tree.insertSelfClosingElement(token);
     881            return;
     882        }
     883        // Fall through to "anything else" case.
    879884    }
    880885    if (token.name() == formTag) {
Note: See TracChangeset for help on using the changeset viewer.