Changeset 62705 in webkit


Ignore:
Timestamp:
Jul 7, 2010 3:00:27 PM (14 years ago)
Author:
jhawkins@chromium.org
Message:

2010-07-07 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add setSuggestedValue to WebInputElement
​https://bugs.webkit.org/show_bug.cgi?id=41785

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setSuggestedValue): (WebKit::WebInputElement::suggestedValue):

2010-07-07 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

Move setSuggestedValue() and suggestedValue() back to public as it's
now used by WebInputElement.
​https://bugs.webkit.org/show_bug.cgi?id=41785

No new tests, as the method is only being used by Chromium's WebKit
API.

  • html/HTMLInputElement.h:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r62703 r62705  
     12010-07-07  James Hawkins  <jhawkins@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Move setSuggestedValue() and suggestedValue() back to public as it's
     6        now used by WebInputElement.
     7        https://bugs.webkit.org/show_bug.cgi?id=41785
     8
     9        No new tests, as the method is only being used by Chromium's WebKit
     10        API.
     11
     12        * html/HTMLInputElement.h:
     13
    1142010-07-07  Mark Rowe  <mrowe@apple.com>
    215

  • trunk/WebCore/html/HTMLInputElement.h

    r61963 r62705  
    125125    virtual void setValueForUser(const String&);
    126126
     127    virtual const String& suggestedValue() const;
     128    void setSuggestedValue(const String&);
     129
    127130    double valueAsDate() const;
    128131    void setValueAsDate(double, ExceptionCode&);
    … …  
    239242
    240243    virtual const AtomicString& formControlType() const;
    241 
    242     virtual const String& suggestedValue() const;
    243     void setSuggestedValue(const String&);
    244244
    245245    virtual bool searchEventsShouldBeDispatched() const;

  • trunk/WebKit/chromium/ChangeLog

    r62702 r62705  
     12010-07-07  James Hawkins  <jhawkins@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [Chromium] Add setSuggestedValue to WebInputElement
     6        https://bugs.webkit.org/show_bug.cgi?id=41785
     7
     8        * public/WebInputElement.h:
     9        * src/WebInputElement.cpp:
     10        (WebKit::WebInputElement::setSuggestedValue):
     11        (WebKit::WebInputElement::suggestedValue):
     12
    1132010-07-07  James Robinson  <jamesr@chromium.org> and Vincent Scheib <schieb@chromium.org>
    214

  • trunk/WebKit/chromium/public/WebInputElement.h

    r60514 r62705  
    8989        WEBKIT_API void setValue(const WebString&);
    9090        WEBKIT_API WebString value() const;
     91        WEBKIT_API void setSuggestedValue(const WebString&);
     92        WEBKIT_API WebString suggestedValue() const;
    9193        WEBKIT_API void setPlaceholder(const WebString&);
    9294        WEBKIT_API WebString placeholder() const;

  • trunk/WebKit/chromium/src/WebInputElement.cpp

    r60514 r62705  
    8686}
    8787
     88void WebInputElement::setSuggestedValue(const WebString& value)
     89{
     90    unwrap<HTMLInputElement>()->setSuggestedValue(value);
     91}
     92
     93WebString WebInputElement::suggestedValue() const
     94{
     95    return constUnwrap<HTMLInputElement>()->suggestedValue();
     96}
     97
    8898void WebInputElement::setPlaceholder(const WebString& value)
    8999{
Note: See TracChangeset for help on using the changeset viewer.