Changeset 62740 in webkit


Ignore:
Timestamp:
Jul 7, 2010 6:52:10 PM (14 years ago)
Author:
tkent@chromium.org
Message:

[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
https://bugs.webkit.org/show_bug.cgi?id=41753

Reviewed by Dimitri Glazkov.

The original code of the following functions in
test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
ASSERT_NOT_REACHED(). The program shouldn't stop at these
functions.

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:

(DRTDevToolsClient::activateWindow):
(DRTDevToolsClient::closeWindow):
(DRTDevToolsClient::dockWindow):
(DRTDevToolsClient::undockWindow):

Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r62739 r62740  
     12010-07-07  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
     6        https://bugs.webkit.org/show_bug.cgi?id=41753
     7
     8        The original code of the following functions in
     9        test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
     10        ASSERT_NOT_REACHED(). The program shouldn't stop at these
     11        functions.
     12
     13        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
     14        (DRTDevToolsClient::activateWindow):
     15        (DRTDevToolsClient::closeWindow):
     16        (DRTDevToolsClient::dockWindow):
     17        (DRTDevToolsClient::undockWindow):
     18
    1192010-07-07  Anders Carlsson  <andersca@apple.com>
    220
  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp

    r62545 r62740  
    7979{
    8080    // Not implemented.
    81     ASSERT_NOT_REACHED();
    8281}
    8382
     
    8584{
    8685    // Not implemented.
    87     ASSERT_NOT_REACHED();
    8886}
    8987
     
    9189{
    9290    // Not implemented.
    93     ASSERT_NOT_REACHED();
    9491}
    9592
     
    9794{
    9895    // Not implemented.
    99     ASSERT_NOT_REACHED();
    10096}
    10197
Note: See TracChangeset for help on using the changeset viewer.