Changeset 62749 in webkit

Timestamp:

Jul 7, 2010 8:34:31 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-07-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix two regressions
​https://bugs.webkit.org/show_bug.cgi?id=41745

• DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion): Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg and svg/custom/use-on-g-containing-foreignObject-and-image.svg though test_shell does it twice. Probably DRT needs it because DRT delays painting as possible.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/WebViewHost.cpp (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-07-07  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [DRT/Chromium] Fix two regressions
+        https://bugs.webkit.org/show_bug.cgi?id=41745
+
+        * DumpRenderTree/chromium/WebViewHost.cpp:
+        (WebViewHost::paintInvalidatedRegion):
+         Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
+         and svg/custom/use-on-g-containing-foreignObject-and-image.svg
+         though test_shell does it twice. Probably DRT needs it because
+         DRT delays painting as possible.
+
 2010-07-07  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp

@@ -1295 +1295 @@
     WebRect clientRect(0, 0, widgetSize.width, widgetSize.height);
 
-    // Paint the canvas if necessary.  Allow painting to generate extra rects the
-    // first time we call it.  This is necessary because some WebCore rendering
+    // Paint the canvas if necessary.  Allow painting to generate extra rects
+    // for the first two calls. This is necessary because some WebCore rendering
     // objects update their layout only when painted.
     // Store the total area painted in total_paint. Then tell the gdk window
     // to update that area after we're done painting it.
-    for (int i = 0; i < 2; ++i) {
+    for (int i = 0; i < 3; ++i) {
         // m_paintRect = intersect(m_paintRect , clientRect)
         int left = max(m_paintRect.x, clientRect.x);
@@ -1316 +1316 @@
         m_paintRect = WebRect();
         paintRect(rect);
-        if (i == 1)
+        if (i >= 1)
             LOG_ERROR("painting caused additional invalidations");
     }