Changeset 62770 in webkit

Timestamp:

Jul 8, 2010 1:49:01 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-08 David Holloway <​dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
use by other code in WebKit/chromium/src.

Specific use of these methods is made in WebFrameImpl.cpp. This is
preferred to the cast operator call that was happening prior to this
change.

​https://bugs.webkit.org/show_bug.cgi?id=41477

• public/WebNode.h:
• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete): (WebKit::WebFrameImpl::getPasswordListener):
• src/WebFrameImpl.h:

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebNode.h (modified) (2 diffs)
• src/WebFrameImpl.cpp (modified) (3 diffs)
• src/WebFrameImpl.h (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-08  David Holloway  <dhollowa@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for 
+        use by other code in WebKit/chromium/src.
+
+        Specific use of these methods is made in WebFrameImpl.cpp.  This is
+        preferred to the cast operator call that was happening prior to this
+        change.
+
+        https://bugs.webkit.org/show_bug.cgi?id=41477
+
+        * public/WebNode.h:
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::registerPasswordListener):
+        (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
+        (WebKit::WebFrameImpl::getPasswordListener):
+        * src/WebFrameImpl.h:
+
 2010-07-07  Pavel Podivilov  <podivilov@chromium.org>
 

trunk/WebKit/chromium/public/WebNode.h

@@ -125 +125 @@
 #endif
 
-protected:
 #if WEBKIT_IMPLEMENTATION
     template<typename T> T* unwrap()
@@ -138 +137 @@
 #endif
 
+protected:
     WebPrivatePtr<WebCore::Node> m_private;
 };

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1980 +1980 @@
     WebPasswordAutocompleteListener* listener)
 {
-    RefPtr<HTMLInputElement> element = inputElement.operator PassRefPtr<HTMLInputElement>();
+    RefPtr<HTMLInputElement> element(inputElement.unwrap<HTMLInputElement>());
     if (!m_passwordListeners.add(element, listener).second) {
         delete listener;
@@ -1991 +1991 @@
     const WebInputElement& inputElement)
 {
-    RefPtr<HTMLInputElement> element = inputElement.operator PassRefPtr<HTMLInputElement>();
-    WebPasswordAutocompleteListener* listener = getPasswordListener(element.get());
+    const HTMLInputElement* element = inputElement.constUnwrap<HTMLInputElement>();
+    WebPasswordAutocompleteListener* listener = getPasswordListener(element);
     // Password listeners need to autocomplete other fields that depend on the
     // input element with autofill suggestions.
@@ -2000 +2000 @@
 
 WebPasswordAutocompleteListener* WebFrameImpl::getPasswordListener(
-    HTMLInputElement* inputElement)
-{
-    return m_passwordListeners.get(RefPtr<HTMLInputElement>(inputElement));
+    const HTMLInputElement* inputElement)
+{
+    return m_passwordListeners.get(RefPtr<HTMLInputElement>(const_cast<HTMLInputElement*>(inputElement)));
 }
 

trunk/WebKit/chromium/src/WebFrameImpl.h

@@ -237 +237 @@
     // Note that the returned listener is owner by the WebFrameImpl and should not
     // be kept around as it is deleted when the page goes away.
-    WebPasswordAutocompleteListener* getPasswordListener(WebCore::HTMLInputElement*);
+    WebPasswordAutocompleteListener* getPasswordListener(const WebCore::HTMLInputElement*);
 
     WebFrameClient* client() const { return m_client; }