Changeset 62771 in webkit

Timestamp:

Jul 8, 2010 2:01:12 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-07-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebCore/benchmarks/parser/html-parser.html spends a lot of time in deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=41807

Wow. This was an awful bug. We were always taking the slow case
every time we parsed a URL. This is about a 10% speedup on our
parsing benchmark, and might cause as much as a 1% speedup for Apple's
PLT (even though I can't run that).

We still spend a lot of time in deprecatedParseURL. We might consider
inlining it if its being kept around much longer.

No behavioral change, just fixing a broken optimization.

• css/CSSHelper.cpp: (WebCore::deprecatedParseURL):
  • We only need to strip characters <= '\r', not >.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSHelper.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-08  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        WebCore/benchmarks/parser/html-parser.html spends a lot of time in deprecatedParseURL
+        https://bugs.webkit.org/show_bug.cgi?id=41807
+
+        Wow.  This was an awful bug.  We were always taking the slow case
+        every time we parsed a URL.  This is about a 10% speedup on our
+        parsing benchmark, and might cause as much as a 1% speedup for Apple's
+        PLT (even though I can't run that).
+
+        We still spend a lot of time in deprecatedParseURL.  We might consider
+        inlining it if its being kept around much longer.
+
+        No behavioral change, just fixing a broken optimization.
+
+        * css/CSSHelper.cpp:
+        (WebCore::deprecatedParseURL):
+         - We only need to strip characters <= '\r', not >.
+
 2010-07-08  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/css/CSSHelper.cpp

@@ -80 +80 @@
     if (l == length) {
         int k;
+        // If the URL has any control characters in it, we have to strip them.
+        // '\r' (ascii value 13) is the largest control character.
         for (k = 0; k < length; k++) {
-            if (characters[k] > '\r')
+            if (characters[k] <= '\r')
                 break;
         }