Changeset 62781 in webkit

Timestamp:

Jul 8, 2010 5:25:27 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Do not invoke shortcuts popup upon bare '?' if it's typed
into an input field.
​https://bugs.webkit.org/show_bug.cgi?id=41760

• inspector/front-end/inspector.js: (WebInspector.documentKeyDown):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-08  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Do not invoke shortcuts popup upon bare '?' if it's typed
+        into an input field.
+        https://bugs.webkit.org/show_bug.cgi?id=41760
+
+        * inspector/front-end/inspector.js:
+        (WebInspector.documentKeyDown):
+
 2010-07-08  Patrick Gansterer  <paroga@paroga.com>
 

trunk/WebCore/inspector/front-end/inspector.js

@@ -723 +723 @@
 WebInspector.documentKeyDown = function(event)
 {
+    var isInputElement = event.target.nodeName === "INPUT";
     var isInEditMode = event.target.enclosingNodeOrSelfWithClass("text-prompt") || WebInspector.isEditingAnyField();
     const helpKey = WebInspector.isMac() ? "U+003F" : "U+00BF"; // "?" for both platforms
 
     if (event.keyIdentifier === "F1" ||
-        (event.keyIdentifier === helpKey && event.shiftKey && (!isInEditMode || event.metaKey))) {
+        (event.keyIdentifier === helpKey && event.shiftKey && (!isInEditMode && !isInputElement || event.metaKey))) {
         WebInspector.shortcutsHelp.show();
         event.stopPropagation();