Changeset 62791 in webkit

Timestamp:

Jul 8, 2010 9:08:33 AM (14 years ago)

Author:

vitalyr@chromium.org

Message:

2010-07-08 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Pavel Feldman.

Fix adoptRef usage violations (mostly in chromium)
​https://bugs.webkit.org/show_bug.cgi?id=41863

• bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::wrapNativeNodeFilter):
• bindings/v8/V8NodeFilterCondition.h: (WebCore::V8NodeFilterCondition::create):
• bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems):
• bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems):
• bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::namedPropertyGetter):
• bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter):
• bindings/v8/custom/V8NamedNodesCollection.h: (WebCore::V8NamedNodesCollection::create): (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
• storage/IDBDatabaseRequest.cpp: (WebCore::IDBDatabaseRequest::IDBDatabaseRequest):
• storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):

2010-07-08 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Pavel Feldman.

Fix adoptRef usage violations (mostly in chromium)
​https://bugs.webkit.org/show_bug.cgi?id=41863

• src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::create):
• src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenu::create):
• src/WebViewImpl.cpp: (WebKit::WebView::create):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/v8/V8DOMWrapper.cpp (modified) (1 diff)
• WebCore/bindings/v8/V8NodeFilterCondition.h (modified) (3 diffs)
• WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp (modified) (1 diff)
• WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp (modified) (1 diff)
• WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp (modified) (1 diff)
• WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp (modified) (1 diff)
• WebCore/bindings/v8/custom/V8NamedNodesCollection.h (modified) (3 diffs)
• WebCore/storage/IDBDatabaseRequest.cpp (modified) (1 diff)
• WebCore/storage/IndexedDatabaseRequest.cpp (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/IDBCallbacksProxy.cpp (modified) (2 diffs)
• WebKit/chromium/src/WebPopupMenuImpl.cpp (modified) (1 diff)
• WebKit/chromium/src/WebViewImpl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-08  Vitaly Repeshko  <vitalyr@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Fix adoptRef usage violations (mostly in chromium)
+        https://bugs.webkit.org/show_bug.cgi?id=41863
+
+        * bindings/v8/V8DOMWrapper.cpp:
+        (WebCore::V8DOMWrapper::wrapNativeNodeFilter):
+        * bindings/v8/V8NodeFilterCondition.h:
+        (WebCore::V8NodeFilterCondition::create):
+        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
+        (WebCore::getNamedItems):
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        (WebCore::getNamedItems):
+        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+        (WebCore::V8HTMLFormElement::namedPropertyGetter):
+        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
+        (WebCore::V8HTMLSelectElement::namedPropertyGetter):
+        * bindings/v8/custom/V8NamedNodesCollection.h:
+        (WebCore::V8NamedNodesCollection::create):
+        (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
+        * storage/IDBDatabaseRequest.cpp:
+        (WebCore::IDBDatabaseRequest::IDBDatabaseRequest):
+        * storage/IndexedDatabaseRequest.cpp:
+        (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
+
 2010-07-08  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/bindings/v8/V8DOMWrapper.cpp

@@ -225 +225 @@
         return 0;
 
-    NodeFilterCondition* condition = new V8NodeFilterCondition(filter);
-    return NodeFilter::create(condition);
+    return NodeFilter::create(V8NodeFilterCondition::create(filter));
 }
 

trunk/WebCore/bindings/v8/V8NodeFilterCondition.h

@@ -34 +34 @@
 #include "NodeFilterCondition.h"
 #include <v8.h>
+#include <wtf/PassRefPtr.h>
 
 // NodeFilter is a JavaScript function that takes a Node as parameter and returns a short (ACCEPT, SKIP, REJECT) as the result.
@@ -44 +45 @@
     class V8NodeFilterCondition : public NodeFilterCondition {
     public:
-        explicit V8NodeFilterCondition(v8::Handle<v8::Value> filter);
+        static PassRefPtr<V8NodeFilterCondition> create(v8::Handle<v8::Value> filter)
+        {
+            return adoptRef(new V8NodeFilterCondition(filter));
+        }
+
         virtual ~V8NodeFilterCondition();
 
@@ -50 +55 @@
 
     private:
+        explicit V8NodeFilterCondition(v8::Handle<v8::Value> filter);
+
         mutable v8::Persistent<v8::Value> m_filter;
     };

trunk/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -53 +53 @@
         return toV8(namedItems.at(0).release());
 
-    NodeList* list = new V8NamedNodesCollection(namedItems);
-    return toV8(list);
+    return toV8(V8NamedNodesCollection::create(namedItems));
 }
 

trunk/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

@@ -53 +53 @@
         return toV8(namedItems.at(0).release());
 
-    NodeList* list = new V8NamedNodesCollection(namedItems);
-    return toV8(list);
+    return toV8(V8NamedNodesCollection::create(namedItems));
 }
 

trunk/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp

@@ -78 +78 @@
         return toV8(elements.at(0).release());
 
-    NodeList* collection = new V8NamedNodesCollection(elements);
-    return toV8(collection);
+    return toV8(V8NamedNodesCollection::create(elements));
 }
 

trunk/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

@@ -71 +71 @@
         return toV8(items.at(0).release());
 
-    NodeList* list = new V8NamedNodesCollection(items);
-    return toV8(list);
+    return toV8(V8NamedNodesCollection::create(items));
 }
 

trunk/WebCore/bindings/v8/custom/V8NamedNodesCollection.h

@@ -34 +34 @@
 #include "Node.h"
 #include "NodeList.h"
+#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Vector.h>
@@ -41 +42 @@
     class V8NamedNodesCollection : public NodeList {
     public:
-        explicit V8NamedNodesCollection(const Vector<RefPtr<Node> >& nodes)
-            : m_nodes(nodes) { }
+        static PassRefPtr<NodeList> create(const Vector<RefPtr<Node> >& nodes)
+        {
+            return adoptRef(new V8NamedNodesCollection(nodes));
+        }
+
         virtual unsigned length() const { return m_nodes.size(); }
         virtual Node* item(unsigned) const;
@@ -48 +52 @@
 
     private:
+        explicit V8NamedNodesCollection(const Vector<RefPtr<Node> >& nodes)
+            : m_nodes(nodes) { }
+
         Vector<RefPtr<Node> > m_nodes;
     };

trunk/WebCore/storage/IDBDatabaseRequest.cpp

@@ -41 +41 @@
 {
     m_this = IDBAny::create();
+    // We pass a reference to this object before it can be adopted.
+    relaxAdoptionRequirement();
     m_this->set(this);
 }

trunk/WebCore/storage/IndexedDatabaseRequest.cpp

@@ -46 +46 @@
 {
     m_this = IDBAny::create();
+    // We pass a reference to this object before it can be adopted.
+    relaxAdoptionRequirement();
     m_this->set(this);
 }
@@ -95 +97 @@
 
 #endif // ENABLE(INDEXED_DATABASE)
-

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-08  Vitaly Repeshko  <vitalyr@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Fix adoptRef usage violations (mostly in chromium)
+        https://bugs.webkit.org/show_bug.cgi?id=41863
+
+        * src/IDBCallbacksProxy.cpp:
+        (WebCore::IDBCallbacksProxy::create):
+        * src/WebPopupMenuImpl.cpp:
+        (WebKit::WebPopupMenu::create):
+        * src/WebViewImpl.cpp:
+        (WebKit::WebView::create):
+
 2010-07-07  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebKit/chromium/src/IDBCallbacksProxy.cpp

@@ -45 +45 @@
 PassRefPtr<IDBCallbacksProxy> IDBCallbacksProxy::create(PassOwnPtr<WebKit::WebIDBCallbacks> callbacks)
 {
-    return new IDBCallbacksProxy(callbacks);
+    return adoptRef(new IDBCallbacksProxy(callbacks));
 }
 
@@ -101 +101 @@
 
 #endif // ENABLE(INDEXED_DATABASE)
-

trunk/WebKit/chromium/src/WebPopupMenuImpl.cpp

@@ -57 +57 @@
 WebPopupMenu* WebPopupMenu::create(WebWidgetClient* client)
 {
-    return new WebPopupMenuImpl(client);
+    // Pass the WebPopupMenuImpl's self-reference to the caller.
+    return adoptRef(new WebPopupMenuImpl(client)).leakRef();
 }
 

trunk/WebKit/chromium/src/WebViewImpl.cpp

@@ -171 +171 @@
 WebView* WebView::create(WebViewClient* client, WebDevToolsAgentClient* devToolsClient)
 {
-    return new WebViewImpl(client, devToolsClient);
+    // Pass the WebViewImpl's self-reference to the caller.
+    return adoptRef(new WebViewImpl(client, devToolsClient)).leakRef();
 }