Changeset 62874 in webkit

Timestamp:

Jul 8, 2010 5:41:00 PM (14 years ago)

Author:

jamesr@google.com

Message:

2010-07-08 James Robinson <​jamesr@google.com>

Reviewed by Darin Fisher.

Allow resizing and getting the texture ID from an offscreen GLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=41828

When using an offscreen GLES2Context the caller needs to be able to resize the backing store
managed by the embedder and get access to a texture id to pass to the compositor. WebGL
does these actions in an indirect way, it will be refactored to use this path.

• public/WebGLES2Context.h:
• src/GLES2Context.cpp: (WebCore::GLES2Context::resizeOffscreenContent): (WebCore::GLES2Context::getOffscreenContentParentTextureId):

2010-07-08 James Robinson <​jamesr@google.com>

Reviewed by Darin Fisher.

Allow resizing and getting the texture id from an offscreen GLES2Context
​https://bugs.webkit.org/show_bug.cgi?id=41828

When using an offscreen GLES2Context the caller needs to be able to resize the backing store
managed by the embedder and get access to a texture id to pass to the compositor. WebGL
does these actions in an indirect way, it will be refactored to use this path.

• platform/chromium/GLES2Context.h:

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/chromium/GLES2Context.h (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebGLES2Context.h (modified) (2 diffs)
• WebKit/chromium/src/GLES2Context.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-08  James Robinson  <jamesr@google.com>
+
+        Reviewed by Darin Fisher.
+
+        Allow resizing and getting the texture id from an offscreen GLES2Context
+        https://bugs.webkit.org/show_bug.cgi?id=41828
+
+        When using an offscreen GLES2Context the caller needs to be able to resize the backing store
+        managed by the embedder and get access to a texture id to pass to the compositor.  WebGL
+        does these actions in an indirect way, it will be refactored to use this path.
+
+        * platform/chromium/GLES2Context.h:
+
 2010-07-02  Ojan Vafai  <ojan@chromium.org>
 

trunk/WebCore/platform/chromium/GLES2Context.h

@@ -39 +39 @@
 
 class GLES2ContextInternal;
+class IntSize;
 class Page;
 
@@ -57 +58 @@
     bool swapBuffers();
 
+    // Only valid for offscreen contexts.
+    void resizeOffscreenContent(const IntSize&);
+
+    // Returns the ID of the texture used for offscreen rendering in the context of the parent.
+    // This texture is accessible by the GPU page compositor.
+    unsigned getOffscreenContentParentTextureId();
+
 private:
     friend class GLES2ContextInternal;

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-08  James Robinson  <jamesr@google.com>
+
+        Reviewed by Darin Fisher.
+
+        Allow resizing and getting the texture ID from an offscreen GLES2Context
+        https://bugs.webkit.org/show_bug.cgi?id=41828
+
+        When using an offscreen GLES2Context the caller needs to be able to resize the backing store
+        managed by the embedder and get access to a texture id to pass to the compositor.  WebGL
+        does these actions in an indirect way, it will be refactored to use this path.
+
+        * public/WebGLES2Context.h:
+        * src/GLES2Context.cpp:
+        (WebCore::GLES2Context::resizeOffscreenContent):
+        (WebCore::GLES2Context::getOffscreenContentParentTextureId):
+
 2010-07-08  Vitaly Repeshko  <vitalyr@chromium.org>
 

trunk/WebKit/chromium/public/WebGLES2Context.h

@@ -37 +37 @@
 namespace WebKit {
 
+class WebSize;
 class WebView;
 
@@ -50 +51 @@
     virtual bool destroy() = 0;
     virtual bool swapBuffers() = 0;
+
+    // The follow two functions are for managing a context that renders offscreen.
+
+    // Resizes the backing store used for offscreen rendering.
+    virtual void resizeOffscreenContent(const WebSize&) = 0;
+
+    // Returns the ID of the texture used for offscreen rendering in the context of the parent.
+    virtual unsigned getOffscreenContentParentTextureId() = 0;
 };
 

trunk/WebKit/chromium/src/GLES2Context.cpp

@@ -32 +32 @@
 
 #include "GLES2Context.h"
+#include "IntSize.h"
 #include "WebGLES2Context.h"
 #include "WebKit.h"
@@ -142 +143 @@
 }
 
+void GLES2Context::resizeOffscreenContent(const IntSize& size)
+{
+    WebGLES2Context* webContext = m_internal->getWebGLES2Context();
+    ASSERT(webContext);
+    webContext->resizeOffscreenContent(size);
+}
+
+unsigned GLES2Context::getOffscreenContentParentTextureId()
+{
+    WebGLES2Context* webContext = m_internal->getWebGLES2Context();
+    ASSERT(webContext);
+    return webContext->getOffscreenContentParentTextureId();
+}
+
 }  // namespace WebCore