Changeset 62889 in webkit
- Timestamp:
- Jul 8, 2010 9:35:21 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r62887 r62889 1 2010-07-08 Tony Chang <tony@chromium.org> 2 3 Reviewed by Ojan Vafai. 4 5 WebCore::InsertLineBreakCommand::shouldUseBreakElement ReadAV@NULL 6 https://bugs.webkit.org/show_bug.cgi?id=30116 7 8 * editing/inserting/return-key-in-hidden-textarea-expected.txt: Added. 9 * editing/inserting/return-key-in-hidden-textarea.html: Added. 10 1 11 2010-07-08 Adam Barth <abarth@webkit.org> 2 12 -
trunk/WebCore/ChangeLog
r62880 r62889 1 2010-07-08 Tony Chang <tony@chromium.org> 2 3 Reviewed by Ojan Vafai. 4 5 WebCore::InsertLineBreakCommand::shouldUseBreakElement ReadAV@NULL 6 https://bugs.webkit.org/show_bug.cgi?id=30116 7 Fixing the crash causes text insertions on hidden elements to get ignored 8 (not a new bug). This is https://bugs.webkit.org/show_bug.cgi?id=40342 9 10 Test: editing/inserting/return-key-in-hidden-textarea.html 11 12 * editing/InsertLineBreakCommand.cpp: 13 (WebCore::InsertLineBreakCommand::doApply): 14 * editing/InsertParagraphSeparatorCommand.cpp: 15 (WebCore::InsertParagraphSeparatorCommand::doApply): 16 1 17 2010-07-08 Sam Weinig <sam@webkit.org> 2 18 -
trunk/WebCore/editing/InsertLineBreakCommand.cpp
r48234 r62889 95 95 96 96 VisiblePosition caret(selection.visibleStart()); 97 // FIXME: If the node is hidden, we should still be able to insert text. 98 // For now, we return to avoid a crash. https://bugs.webkit.org/show_bug.cgi?id=40342 99 if (caret.isNull()) 100 return; 101 97 102 Position pos(caret.deepEquivalent()); 98 103 -
trunk/WebCore/editing/InsertParagraphSeparatorCommand.cpp
r60408 r62889 173 173 || isTableCell(startBlock) 174 174 || startBlock->hasTagName(formTag) 175 || (canonicalPos.node()->renderer() && canonicalPos.node()->renderer()->isTable()) 176 || canonicalPos.node()->hasTagName(hrTag)) { 175 // FIXME: If the node is hidden, we don't have a canonical position so we will do the wrong thing for tables and <hr>. https://bugs.webkit.org/show_bug.cgi?id=40342 176 || (!canonicalPos.isNull() && canonicalPos.node()->renderer() && canonicalPos.node()->renderer()->isTable()) 177 || (!canonicalPos.isNull() && canonicalPos.node()->hasTagName(hrTag))) { 177 178 applyCommandToComposite(InsertLineBreakCommand::create(document())); 178 179 return;
Note: See TracChangeset
for help on using the changeset viewer.