Changeset 63040 in webkit


Ignore:
Timestamp:
Jul 9, 2010 9:32:27 PM (14 years ago)
Author:
jam@chromium.org
Message:

2010-07-09 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
https://bugs.webkit.org/show_bug.cgi?id=42011

  • public/WebPlugin.h: (WebKit::WebPlugin::startFind):
Location:
trunk/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/chromium/ChangeLog

    r63032 r63040  
     12010-07-09  John Abd-El-Malek  <jam@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
     6        https://bugs.webkit.org/show_bug.cgi?id=42011
     7
     8        * public/WebPlugin.h:
     9        (WebKit::WebPlugin::startFind):
     10
    1112010-07-09  Leon Clarke  <leonclarke@google.com>
    212
  • trunk/WebKit/chromium/public/WebPlugin.h

    r62822 r63040  
    5151template <typename T> class WebVector;
    5252
    53 //FIXME: remove once the find functions below are rolled into chromium.
    54 #define WEBPLUGIN_HAS_FIND_INTERFACE
     53// FIXME: remove once the chromium is updated.
     54#define WEBPLUGIN_FIND_HAS_RETURN_TYPE
    5555
    5656class WebPlugin {
     
    106106
    107107    // Find interface.
    108     // Returns true if the plugin supports text search.
    109     virtual bool supportsFind() { return false; }
    110108    // Start a new search.  The plugin should search for a little bit at a time so that it
    111109    // doesn't block the thread in case of a large document.  The results, along with the
    112110    // find's identifier, should be sent asynchronously to WebFrameClient's reportFindInPage* methods.
    113     virtual void startFind(const WebString& searchText, bool caseSensitive, int identifier) { }
     111    // Returns true if the search started, or false if the plugin doesn't support search.
     112    virtual bool startFind(const WebString& searchText, bool caseSensitive, int identifier) { return false; }
    114113    // Tells the plugin to jump forward or backward in the list of find results.
    115114    virtual void selectFindResult(bool forward) { }
Note: See TracChangeset for help on using the changeset viewer.